Files
fusion/packages/dashboard/app/components/BackgroundTasksIndicator.tsx
gsxdsm b6c15fe470 FN-5855: fix frozen dashboard spinners
Restore shared spinner animation behavior for dashboard AI activity indicators.

- switch BackgroundTasksIndicator loaders to the shared animate-spin utility class
- anchor shared spin utilities on SVG centers with transform-origin and transform-box rules
- add CSS regression tests covering global spin keyframes and spinner utility styles

Files changed:
 .../app/__tests__/spinner-animation.css.test.ts    | 50 ++++++++++++++++++++++
 .../app/components/BackgroundTasksIndicator.tsx    |  9 ++--
 packages/dashboard/app/styles.css                  |  7 +++
 3 files changed, 60 insertions(+), 6 deletions(-)

Fusion-Task-Id: FN-5855

Fusion-Task-Lineage: b94d4333-2e78-4c4b-a304-5a13b797bbc6
2026-06-01 23:29:21 -07:00

228 lines
8.3 KiB
TypeScript

import "./BackgroundTasksIndicator.css";
import { useState, useRef, useEffect, useMemo } from "react";
import { Lightbulb, Layers, Target, Loader2, HelpCircle, X, Lock, AlertCircle } from "lucide-react";
import type { AiSessionSummary } from "../api";
import { useAiSessionSync } from "../hooks/useAiSessionSync";
import { useConfirm } from "../hooks/useConfirm";
import { getSessionTabId } from "../utils/getSessionTabId";
interface BackgroundTasksIndicatorProps {
sessions: AiSessionSummary[];
generating: number;
needsInput: number;
onOpenSession: (session: AiSessionSummary) => void;
onDismissSession: (id: string) => void;
}
const TYPE_ICONS = {
planning: Lightbulb,
subtask: Layers,
mission_interview: Target,
milestone_interview: Target,
slice_interview: Target,
} as const;
const TYPE_LABELS = {
planning: "Planning",
subtask: "Subtask Breakdown",
mission_interview: "Mission Interview",
milestone_interview: "Milestone Interview",
slice_interview: "Slice Interview",
} as const;
export function BackgroundTasksIndicator({
sessions,
generating,
needsInput,
onOpenSession,
onDismissSession,
}: BackgroundTasksIndicatorProps) {
const { confirm } = useConfirm();
const [popoverOpen, setPopoverOpen] = useState(false);
const [recentlyUpdated, setRecentlyUpdated] = useState<Set<string>>(new Set());
const containerRef = useRef<HTMLDivElement>(null);
const previousSessionSignatureRef = useRef<Map<string, string>>(new Map());
const clearUpdatedTimerRef = useRef<ReturnType<typeof setTimeout> | null>(null);
const { activeTabMap } = useAiSessionSync();
const localSessionTabId = useMemo(() => getSessionTabId(), []);
// Close popover on outside click
useEffect(() => {
if (!popoverOpen) return;
const handler = (e: MouseEvent) => {
if (containerRef.current && !containerRef.current.contains(e.target as Node)) {
setPopoverOpen(false);
}
};
document.addEventListener("mousedown", handler);
return () => document.removeEventListener("mousedown", handler);
}, [popoverOpen]);
// Animate per-item changes when session status/lock/timestamp changes.
useEffect(() => {
const changed = new Set<string>();
const nextSignature = new Map<string, string>();
for (const session of sessions) {
const ownership = activeTabMap.get(session.id);
const signature = [
session.status,
session.updatedAt,
ownership?.tabId ?? session.lockedByTab ?? "",
ownership?.stale ? "stale" : "fresh",
].join("|");
const previous = previousSessionSignatureRef.current.get(session.id);
if (previous && previous !== signature) {
changed.add(session.id);
}
nextSignature.set(session.id, signature);
}
previousSessionSignatureRef.current = nextSignature;
if (changed.size === 0) {
return;
}
setRecentlyUpdated(changed);
if (clearUpdatedTimerRef.current) {
clearTimeout(clearUpdatedTimerRef.current);
}
clearUpdatedTimerRef.current = setTimeout(() => {
setRecentlyUpdated(new Set());
clearUpdatedTimerRef.current = null;
}, 500);
return () => {
if (clearUpdatedTimerRef.current) {
clearTimeout(clearUpdatedTimerRef.current);
clearUpdatedTimerRef.current = null;
}
};
}, [activeTabMap, sessions]);
if (sessions.length === 0) return null;
const total = sessions.length;
const hasAttention = needsInput > 0;
return (
<div ref={containerRef} className="background-tasks-indicator">
<button
className={`background-tasks-indicator__pill${hasAttention ? " background-tasks-indicator__pill--attention" : ""}`}
onClick={() => setPopoverOpen((prev) => !prev)}
title={`${total} background AI task${total !== 1 ? "s" : ""}${needsInput > 0 ? ` (${needsInput} need${needsInput !== 1 ? "" : "s"} input)` : ""}`}
>
{generating > 0 && (
<Loader2 size={12} className="animate-spin" />
)}
{needsInput > 0 && generating === 0 && <HelpCircle size={12} />}
<span>AI {total}</span>
</button>
{popoverOpen && (
<div className="background-tasks-indicator__popover">
<div className="background-tasks-indicator__popover-header">
Background Tasks
</div>
<div className="background-tasks-indicator__popover-list">
{sessions.map((session) => {
const Icon = TYPE_ICONS[session.type];
const isGenerating = session.status === "generating";
const isAwaiting = session.status === "awaiting_input";
const isError = session.status === "error";
const activeTab = activeTabMap.get(session.id);
const owningTabId = activeTab?.tabId ?? session.lockedByTab ?? null;
const activeElsewhere = Boolean(
owningTabId && owningTabId !== localSessionTabId && !activeTab?.stale,
);
const isUpdated = recentlyUpdated.has(session.id);
return (
<div
key={session.id}
className={`background-tasks-indicator__item${isUpdated ? " background-tasks-indicator__item--updated" : ""}`}
style={{
transition: "background-color 220ms ease, transform 220ms ease",
backgroundColor: isUpdated
? "var(--color-accent-soft, rgba(59, 130, 246, 0.14))"
: undefined,
transform: isUpdated ? "translateY(-1px)" : undefined,
}}
onClick={async () => {
if (activeElsewhere) {
const shouldOpen = await confirm({
title: "Open Active Session",
message: "This session is active in another tab. Open anyway?",
});
if (!shouldOpen) {
return;
}
}
onOpenSession(session);
setPopoverOpen(false);
}}
>
{isError ? (
<AlertCircle size={14} className="background-tasks-indicator__session-icon" style={{ color: "var(--color-error)" }} />
) : (
<Icon size={14} className="background-tasks-indicator__session-icon" />
)}
<div className="background-tasks-indicator__session-content">
<div className="background-tasks-indicator__session-title">
{session.title}
</div>
<div className="background-tasks-indicator__session-meta">
{isError ? "Failed" : TYPE_LABELS[session.type]}
{isGenerating && " — generating..."}
{isAwaiting && !activeElsewhere && " — needs input"}
{isAwaiting && activeElsewhere && " — active in another tab"}
</div>
</div>
{isGenerating && (
<Loader2
size={14}
className="background-tasks-indicator__session-icon animate-spin"
style={{ color: "var(--color-success)" }}
/>
)}
{isAwaiting && !activeElsewhere && (
<HelpCircle
size={14}
className="background-tasks-indicator__session-icon"
style={{ color: "var(--triage)" }}
/>
)}
{isAwaiting && activeElsewhere && (
<Lock
size={14}
className="background-tasks-indicator__session-icon"
style={{ color: "var(--text-muted)" }}
/>
)}
<button
className="background-tasks-indicator__item-dismiss"
onClick={(e) => {
e.stopPropagation();
onDismissSession(session.id);
}}
title="Dismiss"
>
<X size={12} />
</button>
</div>
);
})}
</div>
</div>
)}
</div>
);
}