Two Android-specific fixes: 1. Keyboard dismissing in main chat. App.tsx derives `mobileKeyboardOpen` from useMobileKeyboard and uses it to gate the `project-content--with-mobile-nav` / `--with-footer` className assignment plus MobileNavBar rendering. When the soft keyboard opened on Android, those classes were removed and the nav unmounted, shrinking padding-bottom by ~80px in a single render. Android Chrome treats the resulting jump of the focused chat input as the focus target moving and instantly dismisses the keyboard. With interactive-widget=resizes-content set on Android, the layout viewport itself shrinks with the keyboard, so the hide-nav-on-keyboard pattern was redundant on Android (and harmful). The whole pattern is now gated to iOS via isIOS(). iOS path is unchanged. 2. Pinch-zoom on kanban. Android Chrome ignores user-scalable=no for a11y, and kanban's overflow-x:auto columns combined with the inflated ICB produce a broken visual when the user zooms out. Adds touch-action: pan-x pan-y to html,body inside the mobile media query (keeps scroll panning, blocks pinch-zoom). Chat and MissionManager were unaffected before because they don't expose a wide horizontal scrollable region. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
142 lines
5.1 KiB
TypeScript
142 lines
5.1 KiB
TypeScript
import { useEffect } from "react";
|
|
|
|
function isMobileDevice(): boolean {
|
|
if (typeof window === "undefined") return false;
|
|
const hasTouchScreen =
|
|
"ontouchstart" in window || navigator.maxTouchPoints > 0;
|
|
const isNarrow = window.innerWidth <= 768;
|
|
return hasTouchScreen && isNarrow;
|
|
}
|
|
|
|
/**
|
|
* The scroll lock is an iOS-specific workaround: iOS Safari shifts the layout
|
|
* viewport on input focus (visualViewport.offsetTop > 0) which pushes the
|
|
* dashboard off-screen, so we pin body via position:fixed to make it
|
|
* unscrollable. Android Chrome does NOT need this — and applying the same
|
|
* fix there is actively harmful: mutating body styles while the soft keyboard
|
|
* is opening causes Chrome to treat it as a focus-target relayout and
|
|
* dismisses the keyboard immediately. So we gate the lock to iOS only.
|
|
*
|
|
* With `interactive-widget=resizes-content` set on the viewport meta, Android
|
|
* Chrome shrinks the layout viewport with the keyboard, so no drift
|
|
* compensation is needed there.
|
|
*/
|
|
export function isIOS(): boolean {
|
|
if (typeof window === "undefined") return false;
|
|
const ua = navigator.userAgent || "";
|
|
// iPad on iPadOS 13+ reports as MacIntel + touch — handle that too.
|
|
return /iPad|iPhone|iPod/.test(ua)
|
|
|| (ua.includes("Macintosh") && navigator.maxTouchPoints > 1);
|
|
}
|
|
|
|
/**
|
|
* Reference-counted body scroll lock for fullscreen mobile overlays.
|
|
*
|
|
* Uses the `position: fixed; top: -scrollY` pattern (the same approach used
|
|
* by Bootstrap, Headless UI, and Stripe Elements) instead of just
|
|
* `overflow: hidden`. The reason: iOS Safari ignores `overflow: hidden` when
|
|
* an input inside a `position: fixed` overlay is focused — it scrolls the
|
|
* document to bring the caret above the soft keyboard, and after dismissal
|
|
* the document can be left scrolled with `visualViewport.offsetTop > 0`,
|
|
* shoving the underlying dashboard (header included) off the top of the
|
|
* screen with a matching gap at the bottom.
|
|
*
|
|
* Pinning `body` with `position: fixed` makes the document genuinely
|
|
* unscrollable, so iOS has nothing to do on focus and leaves the visible
|
|
* area aligned with the layout viewport.
|
|
*
|
|
* Reference counting matters because multiple overlays can be open at once
|
|
* (e.g. a confirm dialog over a TodoModal) — only the outermost lock should
|
|
* actually mutate styles, so an inner unmount doesn't release the lock for
|
|
* an outer overlay that is still open.
|
|
*/
|
|
let lockCount = 0;
|
|
let savedStyles: {
|
|
htmlOverflow: string;
|
|
bodyPosition: string;
|
|
bodyTop: string;
|
|
bodyLeft: string;
|
|
bodyRight: string;
|
|
bodyWidth: string;
|
|
bodyOverflow: string;
|
|
scrollY: number;
|
|
} | null = null;
|
|
|
|
function applyLock(): void {
|
|
if (typeof window === "undefined") return;
|
|
if (lockCount > 0) {
|
|
lockCount += 1;
|
|
return;
|
|
}
|
|
const html = document.documentElement;
|
|
const body = document.body;
|
|
savedStyles = {
|
|
htmlOverflow: html.style.overflow,
|
|
bodyPosition: body.style.position,
|
|
bodyTop: body.style.top,
|
|
bodyLeft: body.style.left,
|
|
bodyRight: body.style.right,
|
|
bodyWidth: body.style.width,
|
|
bodyOverflow: body.style.overflow,
|
|
scrollY: window.scrollY,
|
|
};
|
|
html.style.overflow = "hidden";
|
|
body.style.position = "fixed";
|
|
body.style.top = `-${savedStyles.scrollY}px`;
|
|
body.style.left = "0";
|
|
body.style.right = "0";
|
|
body.style.width = "100%";
|
|
body.style.overflow = "hidden";
|
|
lockCount = 1;
|
|
}
|
|
|
|
function releaseLock(): void {
|
|
if (typeof window === "undefined") return;
|
|
if (lockCount === 0) return;
|
|
lockCount -= 1;
|
|
if (lockCount > 0 || !savedStyles) return;
|
|
const html = document.documentElement;
|
|
const body = document.body;
|
|
const { htmlOverflow, bodyPosition, bodyTop, bodyLeft, bodyRight, bodyWidth, bodyOverflow, scrollY } = savedStyles;
|
|
html.style.overflow = htmlOverflow;
|
|
body.style.position = bodyPosition;
|
|
body.style.top = bodyTop;
|
|
body.style.left = bodyLeft;
|
|
body.style.right = bodyRight;
|
|
body.style.width = bodyWidth;
|
|
body.style.overflow = bodyOverflow;
|
|
savedStyles = null;
|
|
// Always snap back to the top, not to the captured `scrollY`. The
|
|
// captured value is only meaningful if the lock was applied before iOS
|
|
// had a chance to forcibly scroll the document (e.g. modal open with
|
|
// no focused input). For App-level activation triggered by an input
|
|
// gaining focus, iOS may have already scrolled the document by the
|
|
// time the lock effect runs — capturing that already-shifted scrollY
|
|
// and restoring to it would leave the dashboard pushed up after the
|
|
// keyboard dismisses (the original bug). The dashboard's base layout
|
|
// has `body { overflow: hidden }` so user-initiated scroll position
|
|
// is always 0 anyway.
|
|
window.scrollTo(0, 0);
|
|
void scrollY;
|
|
}
|
|
|
|
/** Test-only: reset the module-level lock state. */
|
|
export function _resetLockState(): void {
|
|
lockCount = 0;
|
|
savedStyles = null;
|
|
}
|
|
|
|
/**
|
|
* Lock body scroll and pin position while a fullscreen mobile overlay is
|
|
* open. Recovers iOS visualViewport drift on cleanup. No-op on desktop.
|
|
*/
|
|
export function useMobileScrollLock(enabled: boolean): void {
|
|
useEffect(() => {
|
|
if (!enabled || !isMobileDevice() || !isIOS()) return;
|
|
applyLock();
|
|
return () => {
|
|
releaseLock();
|
|
};
|
|
}, [enabled]);
|
|
}
|