1cf86baa1c
## Summary
Wave 18 continues the package code-organization program after wave 17
domain folders (U4 Slice A from
`docs/plans/2026-07-14-001-refactor-package-code-organization-plan.md`).
### What changed
Peel **pure, behavior-preserving** helpers out of
`packages/engine/src/executor.ts` into domain modules under
`packages/engine/src/executor/`, with **stable re-exports** from
`executor.ts` so deep imports and `vi.mock("../executor.js")` keep
working.
| New module | Symbols |
|------------|---------|
| `executor/task-done-refusal.ts` | `evaluateTaskDoneRefusal`,
`determineRevisionResetStart`, skip-bypass refusal helper |
| `executor/workflow-feedback-paths.ts` |
`extractReferencedPathsFromWorkflowFeedback`,
`isAlwaysAllowedScopeLeakPath`, `workflowPathMatchesDeclaredScope` |
| `executor/workflow-step-verdict.ts` |
`FUSION_WORKFLOW_STEP_CONVENTIONS_PREAMBLE`, `parseWorkflowStepVerdict`
/ `parseWorkflowStepOutput`, step outcome types |
| `executor/await-input-parse.ts` | `parseAwaitInputSentinel`,
`parseAwaitInputQuestionToolCall` |
| `executor/no-commit-eligibility.ts` | `getNoCommitEligibilityReason`
(+ prompt heuristics) |
`executor.ts` live LOC ~**22817 → ~22427** (first pure-peel batch; more
peels needed to approach the 2k cap).
### Shims
- `old path` `executor.ts` public exports → `new path` `executor/*.ts` →
delete-when consumer deep-imports are re-pointed (not this PR)
### Test plan
- [x] `@fusion/engine` typecheck
- [x] Oracle: task-done refusal, skip-bypass, workflow malformed
verdict, scope-leak allowlist, executor-step-session, executor-prompt
- [x] `vitest --project=engine-core` (merge-gate curated suite)
- [ ] CI merge gate
**Stack:** wave17 (merged) → **this PR**
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **New Features**
* Improved recognition of workflow outcomes from structured and
conversational responses.
* Added support for extracting questions from await-input responses and
tool calls.
* Improved workflow feedback handling for referenced files and declared
scope patterns.
* Added clearer guidance for task execution, approvals, verification,
and available tools.
* **Bug Fixes**
* Prevented completion when required review approvals are missing or
revisions remain pending.
* Improved handling of workflows that legitimately require no code
changes.
* Added clearer refusal messages and more reliable revision restarts.
* Sanitized repository paths in Git remediation instructions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
44 lines
1.6 KiB
TypeScript
44 lines
1.6 KiB
TypeScript
/**
|
|
* FNXC:CodeOrganization 2026-08-03-17:00:
|
|
* abortAllSessionBash peeled from TaskExecutor (U4).
|
|
*
|
|
* Abort the in-flight bash subprocess (if any) on every active agent session.
|
|
* Invoked at runtime shutdown so detached subprocess trees spawned by agent bash
|
|
* tools — including grandchildren like vitest workers — are killed via
|
|
* pi-coding-agent's killProcessTree. Without this, when the worker is killed those
|
|
* process groups are orphaned because they're detached. Sessions are not disposed
|
|
* here so any near-complete agent loop still has a chance to wrap up during the
|
|
* runtime's graceful drain window.
|
|
*/
|
|
import { executorLog } from "../logger.js";
|
|
|
|
export type AbortAllSessionBashDeps = {
|
|
activeSessions: Map<string, { session: { abortBash: () => void } }>;
|
|
childSessions: Map<string, { abortBash: () => void }>;
|
|
activeStepExecutors: Map<string, { abortAllSessionBash: () => void }>;
|
|
};
|
|
|
|
export function abortAllSessionBash(deps: AbortAllSessionBashDeps): void {
|
|
for (const [taskId, { session }] of deps.activeSessions) {
|
|
try {
|
|
session.abortBash();
|
|
} catch (err) {
|
|
executorLog.warn(`abortAllSessionBash: failed for task ${taskId}: ${err}`);
|
|
}
|
|
}
|
|
for (const [agentId, session] of deps.childSessions) {
|
|
try {
|
|
session.abortBash();
|
|
} catch (err) {
|
|
executorLog.warn(`abortAllSessionBash: failed for child agent ${agentId}: ${err}`);
|
|
}
|
|
}
|
|
for (const [taskId, stepExecutor] of deps.activeStepExecutors) {
|
|
try {
|
|
stepExecutor.abortAllSessionBash();
|
|
} catch (err) {
|
|
executorLog.warn(`abortAllSessionBash: failed for step executor ${taskId}: ${err}`);
|
|
}
|
|
}
|
|
}
|