gsxdsm ee00d9f1b7 FN-5928: enforce surface enumeration for bug-fix invariants ...

Require bug-fix specs and reviews to enumerate affected surfaces and reject repro-only regression coverage.

- add a required `## Surface Enumeration` section to triage prompt templates and bug-fix planning guidance
- tighten reviewer guidance to block missing surface enumeration and repro-only regression tests
- document the canonical surface checklist in `docs/testing.md` and cover the new wording with prompt/reviewer tests

Files changed:
 AGENTS.md                                         |  6 ++--
 docs/testing.md                                   |  9 +++++
 packages/core/src/__tests__/agent-prompts.test.ts | 22 ++++++++++++
 packages/core/src/agent-prompts.ts                | 16 +++++++++
 packages/engine/src/__tests__/reviewer.test.ts    | 17 ++++++++++
 packages/engine/src/__tests__/triage.test.ts      | 41 ++++++++++++++++++++---
 packages/engine/src/reviewer.ts                   |  3 ++
 packages/engine/src/triage.ts                     | 24 +++++++++++++
 8 files changed, 131 insertions(+), 7 deletions(-)

Fusion-Task-Id: FN-5928
Fusion-Task-Lineage: 717ddcbe-f3a6-4589-ad90-4e640f7a9ff2

2026-06-02 21:57:21 -07:00

..

__tests__

FN-5928: enforce surface enumeration for bug-fix invariants

2026-06-02 21:57:21 -07:00

auto-recovery-handlers

fix(engine): un-deadcode bootstrap-misbinding auto-recovery fallback

2026-05-23 02:29:38 -07:00

experiment

FN-5782: wire branch groups into merge routing

2026-05-31 13:50:23 -07:00

external-integrations

feat(FN-5321): add evidence gap detector for external integration manifests

2026-05-20 15:54:44 -07:00

ipc

FN-5703: forward task:deleted events through in-process runtime

2026-05-29 20:05:14 -07:00

notification

FN-5890: include task description in ntfy task-created notifications

2026-06-02 10:29:34 -07:00

providers

FN-5638: migrate pi-ai and pi-coding-agent packages to @earendil-works scope

2026-05-28 21:23:48 -07:00

recovery

feat(FN-5349): add integration branch resolver with auto-recovery fallback

2026-05-21 12:04:58 -07:00

remote-access

feat(FN-5189): complete Step 3 — migrate supervised spawns

2026-05-19 17:19:02 -07:00

research

fix: Replace htmlUrl with url in gh search repos query

2026-05-23 22:09:25 -03:00

runtimes

FN-5901: reap stale mission validator runs

2026-06-02 15:33:31 -07:00

sandbox

feat(FN-5189): complete Step 3 — migrate supervised spawns

2026-05-19 17:19:02 -07:00

spec-validation

feat(FN-5321): add evidence gap detector for external integration manifests

2026-05-20 15:54:44 -07:00

test

…

active-session-registry.ts

fix(FN-5256): keep live task worktrees through pause/resume races

2026-05-21 09:06:23 -07:00

agent-action-gate.ts

…

agent-assignment.ts

…

agent-heartbeat.ts

FN-5759: inject active-goal context across engine lanes

2026-05-30 21:54:06 -07:00

agent-instructions.ts

feat(FN-4393): complete Step 3 — branch memory inclusion by mode

2026-05-13 23:41:35 -07:00

agent-logger.ts

…

agent-memory-index.ts

feat(FN-4393): complete Step 2 — add memory index builder

2026-05-13 23:41:35 -07:00

agent-reflection.ts

…

agent-runtime.ts

FN-5638: migrate pi-ai and pi-coding-agent packages to @earendil-works scope

2026-05-28 21:23:48 -07:00

agent-self-improve.ts

…

agent-session-helpers.ts

FN-5638: migrate pi-ai and pi-coding-agent packages to @earendil-works scope

2026-05-28 21:23:48 -07:00

agent-tools.ts

FN-5638: migrate pi-ai and pi-coding-agent packages to @earendil-works scope

2026-05-28 21:23:48 -07:00

already-merged-detector.ts

FN-5818: fix shared-branch-group execution to use per-task working branches

2026-06-01 01:37:25 -07:00

auth-storage.ts

FN-5638: migrate pi-ai and pi-coding-agent packages to @earendil-works scope

2026-05-28 21:23:48 -07:00

auto-claim-snapshot.ts

fix(FN-5137): complete Step 2-3 — guard deleted tasks in snapshot and executor

2026-05-19 07:45:12 -07:00

auto-recovery.ts

feat(FN-5348): remove cwd-main integration mode fallback

2026-05-21 12:49:50 -07:00

backlog-pressure-reporter.ts

feat(FN-5009): merge fusion/fn-5009

2026-05-18 12:31:21 -07:00

branch-attribution.ts

fix(FN-5304): guard against silent no-op landed-file attribution mismatches

2026-05-20 08:23:40 -07:00

branch-autocorrect.ts

fix(FN-5456): tidy autocorrect shell quoting and disambiguate checkout

2026-05-23 00:03:12 -07:00

branch-conflicts.ts

fix: treat origin/main commits as integrated contamination base

2026-05-30 15:15:47 -07:00

concurrency.ts

…

context-limit-detector.ts

…

cron-runner.ts

…

custom-providers.ts

FN-5833: fix custom Responses API model lookup

2026-06-01 08:23:02 -07:00

dependency-blocked-todo-reporter.ts

fix(FN-5091): harden maxAutoMergeRetries settings parsing

2026-05-19 03:21:18 -07:00

effective-node.ts

…

engine-singleton-lock.ts

feat(engine): guard one engine per project per machine

2026-05-19 22:50:39 -07:00

ephemeral-worker-manager.ts

fix: avoid same-column task move errors and keep durable agents active

2026-05-14 19:26:58 -07:00

error-classifier.ts

…

eval-followups.ts

feat(FN-5232): add deterministic verification-followup deduplication to pre

2026-05-19 19:28:05 -07:00

evaluator-evidence.ts

FN-5697: retry transient auto-merge failures and fix migration versioning

2026-05-29 10:23:59 -07:00

evaluator.ts

…

executor.ts

FN-5889: suppress post-done continuation wedges

2026-06-02 11:03:18 -07:00

experiment-executor.ts

feat(FN-4219): complete Step 4 — add experiment executor runtime

2026-05-14 00:58:44 -07:00

fallback-model-observer.ts

…

gating-classifications.ts

FN-5764: expose mission assertion backfill through API and CLI

2026-05-31 08:32:01 -07:00

goal-anchoring-audit.ts

FN-5758: add cited-goal audit aggregation and runtime route

2026-05-30 22:53:24 -07:00

goal-context-injector.ts

FN-5651: add single-seam goal-context injector for system prompts

2026-05-29 07:11:00 -07:00

goal-injection-diagnostics.ts

FN-5758: add cited-goal audit aggregation and runtime route

2026-05-30 22:53:24 -07:00

gridlock-detector.ts

…

group-merge-coordinator.ts

FN-5846: route shared-group member finalization to shared branch

2026-06-01 20:19:37 -07:00

heartbeat-procedure-resolver.ts

feat(FN-4400): complete Step 3 — add heartbeat prompt template resolver

2026-05-14 04:32:42 -07:00

heartbeat-prompt-trim.ts

fix(FN-4400): preserve triggering comment headings in trim helper

2026-05-14 04:32:43 -07:00

hybrid-executor-gate.ts

perf(dashboard): speed up startup and eliminate API request storms

2026-05-26 21:57:31 -07:00

hybrid-executor.ts

feat(FN-4813): complete Step 5 — add isolation transition runtime restart path

2026-05-16 17:31:09 -07:00

index.ts

FN-5872: clear active-session registry on PR cleanup

2026-06-02 07:46:38 -07:00

integration-branch.ts

feat(FN-5349): add integration branch resolver with auto-recovery fallback

2026-05-21 12:04:58 -07:00

logger.ts

…

merger-ai.ts

FN-5874: persist fast-forward merge details

2026-06-02 08:35:47 -07:00

merger-audit-recovery.ts

…

merger-auto-prerebase.ts

fix(FN-5627): always rebase behind branches before squash (safety fallback)

2026-05-28 15:04:41 -07:00

merger-bare-subject.ts

fix(engine): harden merge finalize SQLite bind and recover bare merge subjects

2026-05-26 21:57:31 -07:00

merger-diff-volume-gate.ts

…

merger-integration-worktree.ts

fix(merger): harden reuse-handoff autostash against shell injection and edit loss

2026-05-22 14:44:21 -07:00

merger-orphan-rehome.ts

feat(merger): auto-rehome FF-recoverable orphan commits in contamination recovery

2026-05-23 09:59:50 -07:00

merger-overlap-guard.ts

…

merger-ref-update-advance.ts

fix(FN-5627): close merger TOCTOU + add fast-path reachability gate

2026-05-28 13:02:30 -07:00

merger-scope-auto-widen.ts

feat(FN-5226): add scope auto-widen layer 2.5 to merger for attribution-bas

2026-05-21 16:30:31 -07:00

merger-squash-audit.ts

…

merger.ts

FN-5909: run configured merge bootstrap before verification

2026-06-02 18:43:29 -07:00

mesh-lease-manager.ts

fix(FN-4826): complete Step 6 — stabilize audit emission and tests

2026-05-16 23:45:17 -07:00

mission-autopilot.ts

FN-5715: gate mission feature completion on assertion validation

2026-05-30 09:43:02 -07:00

mission-execution-loop.ts

FN-5902: make mission validation AI-run all criteria

2026-06-02 18:11:26 -07:00

mission-feature-sync.ts

FN-5715: gate mission feature completion on assertion validation

2026-05-30 09:43:02 -07:00

node-dispatch-validation.ts

…

node-health-monitor.ts

…

node-routing-policy.ts

feat(FN-4813): complete Step 3 — add owning-node handoff policy

2026-05-16 17:31:09 -07:00

notifier.ts

FN-5634: fix ntfy JSON publish priority mapping

2026-05-28 21:17:02 -07:00

peer-exchange-service.ts

…

permanent-agent-gating.ts

…

pi.ts

FN-5833: fix custom Responses API model lookup

2026-06-01 08:23:02 -07:00

plugin-runner.ts

FN-5638: migrate pi-ai and pi-coding-agent packages to @earendil-works scope

2026-05-28 21:23:48 -07:00

pr-comment-handler.ts

feat(FN-5232): add deterministic verification-followup deduplication to pre

2026-05-19 19:28:05 -07:00

pr-monitor-gh.ts

…

pr-monitor.ts

…

project-engine-manager.ts

feat(engine): guard one engine per project per machine

2026-05-19 22:50:39 -07:00

project-engine.ts

FN-5846: route shared-group member finalization to shared branch

2026-06-01 20:19:37 -07:00

project-manager.ts

FN-5703: forward task:deleted events through in-process runtime

2026-05-29 20:05:14 -07:00

project-runtime.ts

FN-5703: forward task:deleted events through in-process runtime

2026-05-29 20:05:14 -07:00

prompt-layers.ts

FN-5653: inject active goal context into heartbeat and executor prompts

2026-05-29 20:05:14 -07:00

rate-limit-retry.ts

…

recovery-policy.ts

…

research-dispatcher.ts

…

research-orchestrator.ts

…

research-step-runner.ts

…

restart-recovery-coordinator.ts

perf(dashboard): cache gh CLI checks and defer SQLite integrity scan

2026-05-26 23:41:28 -07:00

retry-burned-logger.ts

fix(FN-4545): wire retry-burn logging and complete handler coverage

2026-05-14 22:16:44 -07:00

reviewer.ts

FN-5928: enforce surface enumeration for bug-fix invariants

2026-06-02 21:57:21 -07:00

room-ambiguity.ts

feat(FN-4861): merge fusion/fn-4861

2026-05-17 02:08:01 -07:00

room-coordination.ts

feat(FN-5425): add coordination notice system for multi-agent room task fil

2026-05-21 00:17:33 -07:00

routine-runner.ts

test(FN-4689): complete Step 2 — add routine sandbox audit tests

2026-05-15 16:38:45 -07:00

routine-scheduler.ts

…

run-audit.ts

FN-5889: suppress post-done continuation wedges

2026-06-02 11:03:18 -07:00

run-verification-tool.ts

FN-5638: migrate pi-ai and pi-coding-agent packages to @earendil-works scope

2026-05-28 21:23:48 -07:00

runtime-resolution.ts

FN-5638: migrate pi-ai and pi-coding-agent packages to @earendil-works scope

2026-05-28 21:23:48 -07:00

scheduler.ts

FN-5818: fix shared-branch-group execution to use per-task working branches

2026-06-01 01:37:25 -07:00

secrets-env-writer.ts

chore: minor cleanups — docs index, test-project fixture, empty catches, triage timestamp guard

2026-05-19 14:22:11 -07:00

self-healing.ts

FN-5901: reap stale mission validator runs

2026-06-02 15:33:31 -07:00

session-skill-context.ts

…

session-token-usage.ts

FN-5638: migrate pi-ai and pi-coding-agent packages to @earendil-works scope

2026-05-28 21:23:48 -07:00

shell-utils.ts

…

skill-resolver.ts

FN-5638: migrate pi-ai and pi-coding-agent packages to @earendil-works scope

2026-05-28 21:23:48 -07:00

smart-pull.ts

feat(engine): export smartPull() library for stash-aware fast-forward

2026-05-23 14:26:57 -07:00

spec-staleness.ts

fix(engine): preserve parked progress through stale-spec checks

2026-05-30 21:53:00 -07:00

stale-task-reporter.ts

feat(FN-4465): complete Step 3 — scheduler stale task reporter

2026-05-14 05:55:16 -07:00

step-session-executor.ts

FN-5638: migrate pi-ai and pi-coding-agent packages to @earendil-works scope

2026-05-28 21:23:48 -07:00

streaming-delta.ts

FN-5803: normalize streamed sentence spacing across message boundaries

2026-05-31 23:24:53 -07:00

stuck-task-detector.ts

test(FN-5168): complete Step 5 — reliability interaction regression

2026-05-19 16:15:25 -07:00

task-agent-sync.ts

feat(FN-4296): complete Step 1 — add task moved agent link sync module

2026-05-14 05:35:34 -07:00

task-completion.ts

…

token-budget-enforcer.ts

feat(FN-4396): merge fusion/fn-4396

2026-05-14 08:24:01 -07:00

token-cap-detector.ts

FN-5638: migrate pi-ai and pi-coding-agent packages to @earendil-works scope

2026-05-28 21:23:48 -07:00

tool-availability.ts

FN-5638: migrate pi-ai and pi-coding-agent packages to @earendil-works scope

2026-05-28 21:23:48 -07:00

transient-error-detector.ts

FN-5866: suppress post-done non-continuable session errors

2026-06-02 01:48:26 -07:00

transient-merge-error-classifier.ts

fix(FN-5627): suppress ntfy notifications for transient merge failures the engine auto-recovers

2026-05-28 15:39:23 -07:00

triage-preflight.ts

fix(FN-4892): harden intake auto-archive fail-open behavior

2026-05-18 00:53:23 -07:00

triage.ts

FN-5928: enforce surface enumeration for bug-fix invariants

2026-06-02 21:57:21 -07:00

usage-limit-detector.ts

…

verification-followup-dedup.ts

feat(FN-5232): add deterministic verification-followup deduplication to pre

2026-05-19 19:28:05 -07:00

verification-utils.ts

feat(FN-4643): complete Step 4 — delegate verification streaming to sandbox backend

2026-05-15 12:12:50 -07:00

web-fetch.ts

…

workflow-graph-executor.ts

FN-5767: wire workflow graph executor to legacy seams

2026-05-31 08:32:01 -07:00

workflow-node-handlers.ts

FN-5767: wire workflow graph executor to legacy seams

2026-05-31 08:32:01 -07:00

workflow-parity-observer.ts

FN-5768: add dual-observe workflow parity instrumentation

2026-05-31 08:32:01 -07:00

workflow-step-tool-policy.ts

FN-5638: migrate pi-ai and pi-coding-agent packages to @earendil-works scope

2026-05-28 21:23:48 -07:00

worktree-acquisition.ts

FN-5818: fix shared-branch-group execution to use per-task working branches

2026-06-01 01:37:25 -07:00

worktree-backend.ts

feat(FN-5519): merge fusion/fn-5519

2026-05-22 22:43:26 -07:00

worktree-db-hydrate.ts

feat(FN-5128): complete Step 2 — add soft-delete guard to hydration

2026-05-19 05:57:57 -07:00

worktree-desktop-artifacts.ts

feat(FN-4938): complete Step 2 — add helper and wire cleanup

2026-05-18 01:50:22 -07:00

worktree-hooks.ts

feat(FN-5519): merge fusion/fn-5519

2026-05-22 22:43:26 -07:00

worktree-names.ts

FN-5818: fix shared-branch-group execution to use per-task working branches

2026-06-01 01:37:25 -07:00

worktree-paths.ts

feat(FN-4623): complete Step 3 — add backend-aware path resolution

2026-05-15 19:37:48 -07:00

worktree-pool.ts

FN-5772: re-anchor nested task worktree paths

2026-05-31 08:32:01 -07:00

worktree-prune.ts

feat(FN-5058): merge fusion/fn-5058

2026-05-18 11:01:32 -07:00

worktree-ref-sync.ts

fix(engine,dashboard): close 7 review findings on merger auto-sync

2026-05-23 15:13:17 -07:00

worktree-stale-lock.ts

feat(FN-4830): complete Step 1 — add stale lock helper

2026-05-16 20:54:33 -07:00

worktree-stale-registration.ts

feat(FN-5063): merge fusion/fn-5063

2026-05-18 15:51:01 -07:00

worktrunk-failure-handler.ts

feat(FN-4626): complete Step 5 — align worktrunk failure payload shape

2026-05-15 22:18:09 -07:00

worktrunk-installer.ts

feat(FN-5321): add evidence gap detector for external integration manifests

2026-05-20 15:54:44 -07:00