fix(notifications): correct subscription CTA path to /dashboard/subscription

The trial-ending / payment-success / payment-failed emails were pointing
to /dashboard/settings?tab=subscription which does not exist; the correct
path is /dashboard/subscription. Referral paths are unchanged.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

apps/api/src/jobs/processors/lifecycle-email.processor.ts

@@ -64,7 +64,7 @@ async function sendTrialEnding(db: Database, now: Date): Promise<number> {
         ctaUrl: buildTrackedUrl(
           "trial-ending",
           r.email,
-          webUrl("/dashboard/settings?tab=subscription"),
+          webUrl("/dashboard/subscription"),
         ),
       },
     );

apps/api/src/notifications/novu.service.ts

@@ -123,7 +123,7 @@ export class NovuService {
       ctaUrl: buildTrackedUrl(
         "payment-success",
         user.email,
-        webUrl("/dashboard/settings?tab=subscription"),
+        webUrl("/dashboard/subscription"),
       ),
     });
   }
@@ -139,7 +139,7 @@ export class NovuService {
       ctaUrl: buildTrackedUrl(
         "payment-failed",
         user.email,
-        webUrl("/dashboard/settings?tab=subscription"),
+        webUrl("/dashboard/subscription"),
       ),
     });
   }