fix(pl24): Volvo + Ford + Opel/Vauxhall + Hyundai/Kia VIN decode (per-brand services) #100
Reference in New Issue
Block a user
Delete Branch "dev"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Promotes the verified per-brand decode fixes (Volvo vinInfoTable, Ford/Opel/Hyundai info-grid). PSA+year already on main via #98. Each verified live on dev. Nissan deferred (upstream-unresolvable), Fiat pending (no corpus).
Volvo decoded as "Volvo {VIN}" with no real model: the generic Ford-shaped parseP4VehicleResponse reads window.vehicles/<title>/<h1>, but Volvo ships model/year/type in a <table id="vinInfoTable"> caption/value grid (Model="V60 Cross Country (19-)", Model yili=2021, Türü="V60 CC II"). 9 vehicles affected (3 dev + 6 prod). - Add a per-brand vehicle-info hook (P4BrandHooks.parseVehicleInfo) to the shared P4 engine (PL24FordLegacyService); brand values win, generic fills gaps. Backward-compatible: no hook → identical. - New thin PL24VolvoService supplies parseVolvoVinInfo (vinInfoTable parser); orchestrator routes LEGACY_VOLVO decode to it. Categories/drill unchanged (shared engine). Verified live vs 6 prod Volvo VINs: all decode real models (S80/S60/S40/V40/EX40·XC40/V60 CC) + correct years; drill intact (motor → 7 subgroups). First step of the per-brand split (shared core + thin brand services). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>Ford decoded with a polluted model ("Ford Nutzfahrzeuge {VIN}: Transit Connect - TC7…", from the page title), a wrong VIN-char year, and empty transmission. The clean data is in the vin-group info grid (Araç Hattı=model line, Üretim tarihi=build date, Vites Kutusu=transmission, Motor Tipi=engine, Gövde Tarzı=body). New thin PL24FordService supplies parseFordVinInfo via the shared P4 brand hook; orchestrator routes LEGACY_FORD to it. Engine/categories/drill unchanged. Verified live vs 9 prod Ford VINs: 7 now decode clean model + correct build-year + transmission (Transit Connect/2006, Mondeo/1997 CD4E Otomatik, Focus/2000, …) — VIN-char years were off by up to a decade and transmission was empty for all. 2 VINs are upstream gaps (no Araç Hattı → unchanged). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>