root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(dashboard): mark GitHub onboarding step done when authenticated via gh CLI

Browse Source 
On the GitHub onboarding step, when GitHub is authenticated via the gh CLI (no OAuth provider),
the "Continue with gh CLI auth" button called setStep("project-setup") directly, skipping the
completion bookkeeping — so "github" was never added to completedSteps and step 2 never checked
off in the progress indicator. Advance via handleNext when ready via gh CLI (marks the step
completed) and via handleSkip when GitHub isn't connected (marks it skipped).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
gsxdsm
2026-07-02 23:31:15 -07:00
parent 4708d0b644
commit 0771c34b0b
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/dashboard/app/components/ModelOnboardingModal.tsx
View File

@@ -2668,7 +2668,15 @@ export function ModelOnboardingModal({
<div className="model-onboarding-github-optional__actions">
<button
className="btn btn-primary btn-sm"
onClick={() => setStep("project-setup")}
/*
* FNXC:Onboarding 2026-07-03-08:00:
* Advance via handleNext/handleSkip (not a raw setStep) so the GitHub step's
* status is recorded. When GitHub is ready via the gh CLI, "Continue with gh CLI
* auth" must COMPLETE the step (handleNext) — previously it jumped to project-setup
* without adding "github" to completedSteps, so step 2 never checked off. When
* GitHub isn't connected, "Continue without GitHub" is a SKIP (handleSkip).
*/
onClick={isGitHubReadyViaCli ? handleNext : handleSkip}
>
{isGitHubReadyViaCli
? t("setup.continueWithGhCli", "Continue with gh CLI auth →")