root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

test: fix stale refinement-title assertions after FN-7165

Browse Source 
Two store-comments refinement tests located the auto-created refinement task by
`title.includes("Refinement")`, but FN-7165 (34efa8b89) intentionally changed
refinement titles to `${sourceId}: ${feedback}` for traceability. The refinement
task is still created correctly (the length assertion passes); only the
identifying substring was stale, so the tests failed on `expect(refinement)
.toBeDefined()`. Match the refinement by its feedback-derived title instead.
No product behavior change.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
gsxdsm
2026-07-10 21:23:17 -07:00
parent 6e74eedf2d
commit 23dd0fcdf4
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/core/src/__tests__/store-comments.test.ts
View File

@@ -207,7 +207,9 @@ describe("TaskStore", () => {
const allTasksAfter = await store.listTasks();
expect(allTasksAfter).toHaveLength(allTasksBefore.length + 1);
const refinement = allTasksAfter.find((t) => t.id !== task.id && t.title?.includes("Refinement"));
// FN-7165 titles refinements as `${sourceId}: ${feedback}` (not "Refinement …"),
// so identify the new task by its feedback-derived title.
const refinement = allTasksAfter.find((t) => t.id !== task.id && t.title?.includes("Need to fix edge case"));
expect(refinement).toBeDefined();
expect(refinement?.column).toBe("triage");
expect(refinement?.dependencies).toContain(task.id);
@@ -572,7 +574,9 @@ describe("TaskStore", () => {
const allTasksAfter = await store.listTasks();
expect(allTasksAfter).toHaveLength(allTasksBefore.length + 1);
const refinement = allTasksAfter.find((t) => t.id !== task.id && t.title?.includes("Refinement"));
// FN-7165 titles refinements as `${sourceId}: ${feedback}` (not "Refinement …"),
// so identify the new task by its feedback-derived title.
const refinement = allTasksAfter.find((t) => t.id !== task.id && t.title?.includes("Need to fix edge case"));
expect(refinement).toBeDefined();
});