root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(desktop): skip native rebuild in electron-builder to unblock Windows release

Browse Source 
electron-builder's default @electron/rebuild step walked the desktop app's
whole dependency tree and tried to source-build @homebridge/node-pty-prebuilt-multiarch
(Node-ABI prebuilds only, none for Electron) via node-gyp, which fails on the
Windows runner with "Could not find any Visual Studio installation". The app
bundles no native addon needing an Electron-ABI rebuild (it uses node:sqlite;
keytar/node-pty aren't in the files list and are loaded optionally), so the
rebuild was pointless. Set npmRebuild: false to skip it on all platforms.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
gsxdsm
2026-06-19 08:14:22 -07:00
parent 82068f0b59
commit c093f4a1e6
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/desktop/electron-builder.yml
View File

@@ -6,6 +6,16 @@ directories:
output: dist-electron
buildResources: src/icons
# The desktop app bundles no native addon that needs an Electron-ABI rebuild: it
# uses Node's built-in `node:sqlite`, and the only native modules in the dependency
# tree (keytar, @homebridge/node-pty-prebuilt-multiarch via @fusion/dashboard) are
# loaded optionally and are NOT in the `files` list, so they're never packaged.
# electron-builder's default rebuild walks the whole tree and tries to source-build
# node-pty (it ships Node-ABI prebuilds only, none for Electron) via node-gyp, which
# fails on the Windows runner ("Could not find any Visual Studio installation").
# Disabling the rebuild skips that pointless, platform-fragile compile entirely.
npmRebuild: false
files:
# pnpm installs workspace/runtime deps as symlinked package entries backed by the
# virtual store. These flat node_modules/X/**/* patterns only work when electron-builder