975d8a0ed2f03f34943282c0ca92cee51ecc65e9
13890 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Fusion Agent
|
975d8a0ed2 |
test(FN-WF): stop non-review gates consuming a scenario's scripted review verdicts
Two places in the pipeline-smoke mock treated any readonly, non-Plan-Review turn
as a Code Review, so on a review-column workflow the Documentation & Delivery gate
ate the verdict scripted for Code Review. S07 scripts
`codeReviewModes: ["empty-revise"]` to exercise an unactionable Code Review
rejection; the card instead died with `documentation-delivery: failed: REVISE`
before Code Review ever ran.
- `emitReview` classified everything that was not Plan Review as "code".
- The executor script forces `emitReview(context, "code")` whenever a readonly
session coincides with scripted `codeReviewModes` — and a documentation gate is
readonly too, so it took that branch as well.
Both now identify the executing step from the workflow-step system prompt
("You are a workflow step agent executing: <name>") and exclude the known
non-review gates. Detection is by EXCLUSION rather than an allow-list on purpose:
the real reviewer prompt does not carry the literal "Code Review", so allow-listing
silently approves every genuine review instead — measured, it turned S07 green on
`builtin:coding-ideas` for the wrong reason.
S07 on builtin:coding-ideas-v2 now gets past that misattribution and reaches the
review seal instead, which is a different and still-open problem, so the scenario
stays on its original workflows. Lane is green and faster than the previous
matrix: 6 files, 82 tests, 19/19 scenarios, 97.2s and 100.3s against the 150s
budget.
|
||
|
Fusion Agent
|
94f660e672 |
fix(FN-WF): stop a failed merge stranding review-column tasks, and widen V2 coverage
Two review-seal defects, both found by running builtin:coding-ideas-v2 through the whole scenario matrix rather than the nominal path alone. 1. A DETERMINISTIC verification gate was sealed as write-capable. It needs a worktree because it runs the project's test/build commands there, but it only reads the tree — `verification-gate.ts` has no mutation path. `workflowNodeRequiresWorktree` conflates "needs a worktree" with "writes", and its inline-fix branch matches on the node NAME (`/review|verification/i`), so a gate named "Verification" was refused after any approval. 2. A gate that already `passed` or was `skipped` was refused on replay. A post-approval requeue — a merge conflict, a transient merge failure — walks the graph back through gates whose output is already inside the approved tree. Refusing them converts a retryable merge into a terminal wedge; re-running them would rewrite the tree the review approved. "Already produced, already reviewed" now resolves as satisfied. A gate with no result still hits the refusal, which is the case the seal exists for. Measured by pipeline-smoke S13, where a conflicting merge left the card cycling on documentation-delivery with `workspace-review-seal-required` instead of retrying. Coverage: builtin:coding-ideas-v2 now runs 16 of the 19 declared scenarios plus the multi-repository workspace drive, up from 1. The duration budget is re-baselined 90s -> 150s, and the workload growth is itemised in docs/testing.md: 17 added scenario executions and a second project shape, 124.95s measured against 76.9s for the smaller matrix. Three consecutive full runs: 116.9s, 115.6s, 119.8s. NOT covered, deliberately and stated rather than hidden: S07 (unactionable review rejection), S13 (scripted merge-conflict resolution) and S17 (restart resilience) still run on the original workflows only. S07 and S13 do not converge on V2, and S17 produced one intermittent post-merge failure in four full-lane runs — a flake is not something to ship or to paper over, so those three stay uncovered until they are understood. |
||
|
Fusion Agent
|
f4487b4b31 |
test(FN-WF): prove the pipeline end to end on multi-repository workspaces
The smoke lane now drives a workspace task on builtin:coding-ideas-v2 from the
Ideas intake to `merged-done`, alongside the existing single-repository coverage.
6 files, 65 tests, 19/19 scenarios, 77.1s of the 90s budget.
Two fixture defects stood between the harness and that proof, both of the same
shape: a workspace task legitimately has NO task-level `branch` — each repository
owns one under `workspaceWorktrees[repo].branch`.
- The scripted merger was handed `task.branch ?? ""`, so it ran
`git merge --squash` on an empty ref ("merge: - not something we can merge"),
surfacing only as the generic "Workspace repository repo1 could not land".
- Resolving the branch at INSTALL time was still wrong: the merge is attempted in
the same turn as the first install, before acquisition has created any
per-repository worktree. The scripts now receive an async getter that reads the
live task when the merger actually runs, so ordering cannot make it stale.
This also corrects an earlier misattribution recorded in the previous commit: the
land failure was NOT a missing `repositoryScope`. A probe showed the scope
confirmed, the review evidence recorded, and `workspaceWorktrees.repo1.branch`
populated — the harness simply never passed that branch to the merger.
The workspace path is now measured, not inferred: plan, plan-review, parse,
verification, documentation-delivery, completion-summary, code review
("All 1 modified in-scope sub-repo(s) approved") and the per-repository land all
run, with `mergeDetails.mergeConfirmed` asserted on the persisted row.
|
||
|
Fusion Agent
|
ec37920593 |
fix(FN-WF): document the V2 remediation gap and the workspace land precondition
Two investigations, both concluded with evidence rather than a shipped guess.
REMEDIATION. builtin:coding-ideas-v2 inherits Coding (Ideas)' `code-review-remediation`
(`pre-merge-remediation`, a send-back that appends no work) while its own
`verification-remediation` uses `review-remediation-steps`, which derives NAMED steps
from the reviewer's findings, appends them as a numbered wave, widens the PROMPT.md
File Scope, and parks for a human instead of bouncing when findings are out of scope,
unactionable, or a fourth wave. Aligning the two was attempted and REVERTED: with the
named path on code review, S05 ("REVISE twice, then approve") fails reproducibly on
this workflow — the card reaches merge without a usable branch and `git merge --squash`
runs with an empty ref ("not something we can merge"). A bounced card that cannot merge
is worse than a bounced card with an unchanged checklist, so the asymmetry is pinned by
a test that states the constraint: change it together with a green S05, never alone.
WORKSPACE. The land failure behind "Workspace repository repo1 could not land" is the
SAME empty-ref signature, and it is a fixture limitation rather than a product defect:
the harness states `repositoryScope` directly, so no acquisition ever populates
`workspaceWorktrees[repo].branch`, and the per-repo land has no branch to squash. The
production path populates it; the fixture must too before the end-to-end workspace
drive can be asserted.
What the workspace work already proved stands: a workspace task clears plan,
plan-review, parse, verification, documentation-delivery and code review
("All 1 modified in-scope sub-repo(s) approved"), which is the direct end-to-end
confirmation that the session-boundary fix works — the write-capable documentation gate
now runs in a multi-repository project instead of dying with "Refusing to start coding
agent in incomplete worktree".
Everything committed here is green: smoke 63 tests / 19/19 scenarios / 72.7s of 90s,
test:gate, verify:fast, both typechecks, changesets.
|
||
|
Fusion Agent
|
c8b2b10732 |
test(FN-WF): add multi-repository workspace support to the pipeline smoke harness
The smoke lane was single-repository only, so the workspace path — the one that
actually broke in production — was never driven end to end. Adds:
- `createPipelineWorkspaceFixture`: a real workspace project whose ROOT is a plain
container (no Git metadata) holding per-repository checkouts with their own
origins and a `.fusion/workspace.json`. The single-repo fixture cannot express
this shape, because there the root and the repository are the same directory —
which is why a node resolving the root as a worktree still worked by accident.
- `PipelineGitFixture.integrationRepoDir`: integration git (`rev-parse main`,
ancestry, status, worktree prune) now targets a repository rather than the
project root. Single-repo fixtures answer `repoDir`, so nothing changes there.
- `PipelineSmokeHarness.create(pg, { workspace: true })` and an optional confirmed
`repositoryScope` on `createPipelineTask`, which workspace acquisition requires
before any write-capable node runs.
- The executor mock now resolves the repository it can commit in. Its
`existsSync(cwd/.git)` guard skipped the whole implementation block on a
workspace session (cwd is the task directory), so no commit existed and Code
Review reported "No changes — not reviewed" on an untouched scoped repository.
Measured with these in place, a workspace task on builtin:coding-ideas-v2 now
clears plan, plan-review, parse, verification, documentation-delivery and code
review ("All 1 modified in-scope sub-repo(s) approved"). That is the direct
end-to-end confirmation that the FN-158-shaped session-boundary fix works: the
write-capable documentation gate runs in a workspace instead of dying with
"Refusing to start coding agent in incomplete worktree".
It then fails at the workspace LAND step with "Workspace repository repo1 could
not land". The underlying cause is written to the task log rather than stdout and
is not yet identified, so the end-to-end workspace drive test is deliberately NOT
committed: shipping it red would put a permanently failing test in the lane, and
weakening it to assert only the progress reached would be appeasement. Mono-repo
coverage is unchanged and green (63 tests, 19/19 scenarios).
|
||
|
Fusion Agent
|
d061081b61 |
chore(FN-WF): retire builtin:review-gated-coding via the registry deprecation list
Adds it to `DEPRECATED_BUILTIN_WORKFLOW_IDS` — the registry's own retirement mechanism, and the reason `isBuiltinWorkflowToggleEligible` and `validateEnabledBuiltinWorkflowIds` exist. The workflow disappears from new selection while `getBuiltinWorkflow` keeps resolving it, so any task that already selected it still runs. Built-ins cannot be deleted, and deleting this one would strand those tasks. It is obsolete because builtin:coding-ideas-v2 supersedes it and because its own success path could never complete: `code-review -> documentation-delivery` puts a write-capable node after a passed review, which the graph refuses with `workspace-review-seal-required`. |
||
|
Fusion Agent
|
9e76393cfa |
fix(FN-WF): make review-column workflows actually merge
A required pre-merge step is not necessarily a content review. Review-column workflows also require a deterministic verification gate (exit codes) and a documentation/delivery gate; neither records a `reviewInputFingerprint` because neither binds a diff. `evaluatePreMergeApprovals` compared them against the merge content anyway, classified both as `unprovable-content`, and `canMergeTask` answered "task has no provable approval for the content being merged" — an unsatisfiable gate, so NOTHING could ever merge on such a workflow. Cards reached the merge, were refused, and looped through verification-remediation. The carve-out is narrow: a step that is neither `code-review` nor a `reviewKind: "code"` result AND recorded no fingerprint of its own is not diff-bound and passes on its status. A content review that DID record a fingerprint is still compared, and a code review missing one is still refused, so FN-180's guarantee is untouched. Reverting the carve-out fails the new tests. builtin:review-gated-coding carried the identical latent defect and never reached its merge to expose it. Proven end to end: pipeline-smoke now drives S01 on builtin:coding-ideas-v2 from the Ideas intake through promotion, planning, plan review, implementation, verification, documentation, summary and code review to `merged-done` — 63 tests, 19/19 scenarios, 74.7s against the 90s budget. S01 keeps that workflow permanently, because all five defects fixed in this effort passed structural review and only a real card reaching `merged-done` exposed them. |
||
|
Fusion Agent
|
3efdc42ad4 |
fix(FN-WF): repair the review-gated planning seam, prompt, and workspace gate boundary
Four defects found by pointing the FN-182 pipeline-smoke harness at a review-gated
workflow. Three of them also affected builtin:review-gated-coding, where they had
been latent because that graph dies earlier on the review seal.
1. `planning-implementation-only` is a PROMPT key, never an executable seam.
`resolveSeamName` accepts exactly seven seam names and throws
`Unsupported workflow seam` otherwise, so the `plan` node threw on every task:
the graph failed at `plan`, the card bounced to todo, and the board reported
"Execution dispatch refused — task is still unplanned" — pressing Start
appeared to do nothing. The seam is now `planning`; only the prompt differs.
2. The seam prompt contradicted itself. It was the full triage prompt — whose
template MANDATES `### Step {N-1}: Testing & Verification` and
`### Step {N}: Documentation & Delivery` — plus one appended line asking for
neither. The template won, so tasks emitted both steps and ran them in
in-progress, duplicating the review gates. The template region is now removed
and replaced by an explicit prohibition. The parse node's
`implementationOnlySteps` is not a backstop: it only audits, by design.
3. `requireImplementationOnlySteps` was inert when set on an already-built
plan-review node: the prompt is assembled by `planReviewOptionalGroupNode`
and no engine code reads the flag, so the reviewer never received its
criterion. Both derived workflows now call `applyImplementationOnlyStepReview`.
4. Write-capable graph nodes declared no session boundary on workspace tasks, so
the single-repo assertion resolved the task DIRECTORY (a container of per-repo
worktrees, no `.git`) as a worktree and refused: "Refusing to start coding
agent in incomplete worktree", failing the gate before a verdict and requeuing
the task. FN-158 gave Code Review the `workspace-task-dir` boundary but not the
generic prompt path. Extracted as a pure `resolveGraphNodeSessionBoundary`.
Also reorders coding-ideas-v2 to `verification -> documentation-delivery ->
completion-summary -> code-review -> merge`. The summary escapes the review seal
(readonly) but still acquires a worktree, and any node between the review and the
merge invalidates FN-180's review-diff fingerprint.
Known incomplete: builtin:coding-ideas-v2 still does not converge end to end —
pipeline-smoke S01 reaches merge and is refused with "task has no provable
approval for the content being merged". Not yet root-caused; the workflow must be
treated as unusable until it is.
|
||
|
Fusion Agent
|
b818eb20ad |
feat(FN-WF): add the Coding (Ideas) V2 workflow with review-column gates
Selectable built-in `builtin:coding-ideas-v2`. It clones the Coding (Ideas) IR
without mutating it, so the manual `ideas` intake (`autoTriage: false`) and the
whole board shape are unchanged, and moves testing and documentation out of the
planner's implementation checklist into visible review-column gates:
in-progress : steps = implementation only
in-review : verification -> documentation-delivery -> code-review
-> completion-summary -> merge-gate -> merge
Ordering is load-bearing, not cosmetic. `execute-workflow-graph.ts` refuses any
write-capable node once a Code Review APPROVE exists, so that a passed review
seals the tree and nothing unreviewed reaches main. `verification-step` and
`documentation-delivery-step` are both write-capable and therefore run BEFORE
the review; `completion-summary` is `toolMode: "readonly"` and runs after it, so
the card blurb describes the state that was actually approved.
Both remediation loops re-enter at `verification`, never at `code-review`: a
REVISE replays verification AND documentation-delivery, so the docs and
changeset are regenerated to include what the review demanded before it re-reads
them. Documentation stays both current and reviewed.
The planner is switched to the `planning-implementation-only` seam so it stops
emitting "Testing & Verification" and "Documentation & Delivery" steps, which
would otherwise duplicate the gates under identical names.
Adds a ratchet running the production `workflowNodeRequiresWorktree` classifier
over the success chain: it reports zero offenders here and correctly flags
`documentation-delivery` on builtin:review-gated-coding, whose post-review
ordering deadlocks every task once its review approves.
|
||
|
Fusion Agent
|
5990ebb752 |
fix(FN-184): stop an in-flight merge aborting on its own merging status
FN-180's in-flight revoke watcher read `runAiMerge`'s own `status:"merging"` stamp as a blocking pre-merge verdict: `merging`/`merging-pr` are members of HARD_BLOCKING_TASK_STATUSES and daemon/dashboard/serve all wire the unoptioned `getTaskMergeBlocker`. The merge aborted itself within the same second, the drain catch cleared the stamp, and the sweep re-admitted the task every `pollIntervalMs` forever. The abort branch spends no `mergeRetries`, so nothing bounded the loop: no task merged, on any project, and no card was ever parked. Fixed at both seams, because the watcher alone leaves the merge dying later: - `ProjectEngine.wireTaskPauseMergeInterruption` evaluates the blocker against a verdict view that neutralizes `isMergeActiveStatus` for the owned task. - `assertMergeGateStillOpen` (merger-ai) re-reads the task from the store at the ref-advance fence, so it observes the same stamp and revoked the very merge it guards. Same neutralization applied. Genuine verdicts still abort: failed/pending pre-merge step results, `paused`, `needs-replan`, and the scheduler's `queued` (deliberately not neutralized — MERGE_CONFIRMED_TRANSIENT_STATUSES would have swallowed it). A merge-active stamp on a different task never enters the branch. Replaces the FN-180 source-grep coverage with behavioral tests driving the real production blocker through the handler. Proven differential: reverting the neutralization fails exactly the `merging` and `merging-pr` cases (2 of 11). Fusion-Task-Id: FN-184 |
||
|
Fusion Agent
|
bde81ad4ff |
feat(FN-182): add deterministic AI-free pipeline smoke lane
Opt-in `pnpm smoke:pipeline` lane replaying 19 declared scenarios across
builtin:coding-ideas and the builtin:coding non-regression floor, driving the
real engine: disposable local Git repositories, throwaway PostgreSQL store,
production graph dispatch, ProjectEngine merge admission, real worktree
acquisition, and deterministic mock-provider scripts under testMode.
Each scenario declares one closed terminal state (merged-done, inert-intake,
parked, manual-hold, no-op-merge); an undeclared terminal fails the run, and
five wedge detectors (W1-W5) reject contradictory parks, finalization loops,
severed sessions, unreachable waits, and quiescence without progress.
Differential proof: on the pre-FN-180 tree (
|
||
|
Fusion Agent
|
8e8e3233c6 |
Merge remote-tracking branch 'origin/main'
# Conflicts: # docs/dashboard-guide.md # packages/core/src/__tests__/postgres/schema-applier.test.ts # packages/core/src/__tests__/task-merge.test.ts # packages/core/src/merge/task-merge.ts # packages/core/src/postgres/schema-applier.ts # packages/core/src/task-store/merge-queue-ops.ts # packages/dashboard/app/__tests__/App.keyboard-shortcuts.test.tsx # packages/dashboard/app/components/ChatView.css # packages/dashboard/app/components/ChatView.tsx # packages/dashboard/app/components/__tests__/ChatView.core-contracts.test.tsx # packages/dashboard/app/components/__tests__/ChatView.core-interactions.test.tsx # packages/dashboard/app/components/__tests__/ChatView.core.test.tsx # packages/dashboard/app/components/__tests__/ChatView.draft.test.tsx # packages/dashboard/app/components/__tests__/ChatView.message-edit.test.tsx # packages/dashboard/app/components/__tests__/ChatView.mobile-render.test.tsx # packages/dashboard/app/components/__tests__/ChatView.mobile.test.tsx # packages/dashboard/app/components/__tests__/ChatView.new-chat-default.test.tsx # packages/dashboard/app/components/__tests__/ChatView.rooms.test.tsx # packages/dashboard/app/components/__tests__/ChatView.scroll-to-top.test.tsx # packages/dashboard/app/components/__tests__/ChatView.sessions-rooms.test.tsx # packages/dashboard/app/components/__tests__/ChatView.thinking-level.test.tsx # packages/engine/src/__tests__/executor-step-session.test.ts # packages/engine/src/__tests__/merge-abort-clears-transient-status.test.ts # packages/engine/src/__tests__/merger-ai-cleanup.test.ts # packages/engine/src/__tests__/merger-merge-lifecycle.test.ts # packages/engine/src/__tests__/workspace-merger.test.ts # packages/engine/src/merge/auto-merge-finalization.ts # packages/engine/src/merge/merger-ai.ts # packages/engine/src/project-engine.ts # packages/engine/src/run-audit/run-audit-catalogue.ts # packages/engine/src/self-healing.ts # packages/engine/src/worktree/review-diff-fingerprint.ts # packages/i18n/locales/es/app.json # packages/i18n/locales/fr/app.json # packages/i18n/locales/ko/app.json # packages/i18n/locales/pt-BR/app.json # packages/i18n/locales/zh-CN/app.json # packages/i18n/locales/zh-TW/app.json |
||
|
gsxdsm
|
456f7b370b |
docs(test-failures): retract the connection-exhaustion cause, record the failed reproduction
Measured 14 backend connections against max_connections=100, so the api-lane hook timeouts are not connection exhaustion; the PostgreSQL Failed query lines are a torn-down reconciler polling after the fact. Full 15-lane run at 23,584 tests reproduced nothing, and the DDL admission gate never degraded, so that mechanism is unsupported too. Records what a future attempt must capture. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> |
||
|
gsxdsm
|
68f5c45ef0 |
chore(dashboard): commit e2e screenshot baselines regenerated by the browser lane
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> |
||
|
Anthony Ettinger
|
544d740ab0 |
ci: scan pull requests for credentials and injection with ThreatCrush (#3427)
Adds a pull-request workflow that scans the diff for hardcoded credentials, injection, SSRF and unsafe deserialisation. Results go to the Security tab as SARIF and to a comment on the pull request. ### What it does on this repository ``` @profullstack/threatcrush@0.11.0 scan . 6908 files in 27.5s — 4570 finding(s): 38 high, 4061 medium, 471 low confidence: 500 evidence, 4070 pattern ``` **None of that is a claim about your code, and I have not verified any of it.** `confidence: pattern` means a regex matched and nothing more; expect false positives in that tier. It is here because the check on this pull request may never run at all — GitHub withholds workflow runs from first-time contributors, and across 24 open requests elsewhere not one has been approved. Rather than ask you to approve a run to find out what it produces, that is what it produces. Opened alongside the question in https://github.com/Runfusion/Fusion/issues/3426, which is the place to say no or ask for changes. This is only the diff, so it is there to read rather than imagine — closing either one is a fine answer. **This is not a CodeQL replacement, and it is worth saying where it differs.** CodeQL does semantic dataflow analysis and is better at it than this is — a repository already running it is not missing much by closing this. Two gaps it does fill: - Code scanning and secret scanning are free on public repositories, but need paid GitHub Code Security / Secret Protection on private ones. This is MIT and free on both, so the same gate can run across a mixed set of repositories. - CodeQL analyses a fixed set of languages, and among compiled ones it analyses only the language with the most source files unless it's explicitly configured otherwise. In a polyglot repository the rest goes unscanned by default; this reads every file it is pointed at. It is additive and report-only, so running both costs a few CI minutes and changes nothing else. **It is report-only.** `failOn` is empty, so it annotates and never fails a build. A repository with pre-existing findings should get a report on its first install, not a blocked pull request — a gate that fires on everything gets switched off within a day. Tighten it to `critical,high` in the workflow once any backlog is triaged. - `.github/workflows/threatcrush-scan.yml` — the workflow - `.github/scripts/threatcrush-to-sarif.py` — a compatibility shim for CLI versions older than native SARIF output; unused once the installed CLI can emit it itself Permissions are least-privilege (`contents: read`, `pull-requests: write`, `security-events: write`). It runs on `pull_request`, not `pull_request_target`, so contributor code never executes with your secrets in scope. The SARIF upload is `continue-on-error` and degrades quietly where code scanning is unavailable. The CLI is pinned to `@profullstack/threatcrush@0.11.0` and installed with `--ignore-scripts`, and checkout runs with `persist-credentials: false`. A scanner that installs a floating version, runs its dependencies' lifecycle scripts and leaves a token in `.git/config` is asking you to trust more than it is worth, and none of that is needed to read a diff. Bump the pin whenever you like — nothing here updates itself. Disclosure: I maintain [ThreatCrush](https://github.com/profullstack/threatcrush). It is free and MIT, and the workflow installs it from npm — nothing here phones home. If this is not something you want, closing it is the right answer, and I will not send another. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added automated ThreatCrush security scanning for pull requests. * Scan results are converted to a standardized format and uploaded for review. * Findings can update pull request comments and generate downloadable reports and artifacts. * Supports current and legacy scanner output formats. * Adds configurable severity thresholds and verified scanner installation. * **Bug Fixes** * Invalid, incomplete, or unrecognized scan output now fails safely with clear diagnostics. * Scan failures and security findings are reliably reported. * Improved handling of scan completion status and finding details. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Anthony Ettinger <anthony@chovy.com> Co-authored-by: gsxdsm <gsxdsm@users.noreply.github.com> |
||
|
dependabot[bot]
|
87a3700a21 |
Bump sharp from 0.33.5 to 0.35.3 (#3509)
Bumps [sharp](https://github.com/lovell/sharp) from 0.33.5 to 0.35.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lovell/sharp/releases">sharp's releases</a>.</em></p> <blockquote> <h2>v0.35.3</h2> <ul> <li> <p>Tighten verification of <code>text</code> dimensions, TIFF tile dimensions and <code>extend</code> values.</p> </li> <li> <p>Improve code bundler support by resolving path to libvips binary.</p> </li> <li> <p>Increase default concurrency when use of <code>MALLOC_ARENA_MAX</code> is detected.</p> </li> <li> <p>Emit warning about binaries provided by Electron for use on Linux.</p> </li> <li> <p>Add <code>hasAlpha</code> property to output <code>info</code>. <a href="https://redirect.github.com/lovell/sharp/issues/4500">#4500</a></p> </li> <li> <p>TypeScript: Return more precise <code>Buffer<ArrayBuffer></code> from <code>toBuffer</code>. <a href="https://redirect.github.com/lovell/sharp/pull/4520">#4520</a> <a href="https://github.com/Andarist"><code>@Andarist</code></a></p> </li> <li> <p>Bound <code>clahe</code> width and height to avoid signed overflow. <a href="https://redirect.github.com/lovell/sharp/pull/4551">#4551</a> <a href="https://github.com/metsw24-max"><code>@metsw24-max</code></a></p> </li> <li> <p>Bound <code>trim</code> margin to avoid signed overflow. <a href="https://redirect.github.com/lovell/sharp/pull/4552">#4552</a> <a href="https://github.com/metsw24-max"><code>@metsw24-max</code></a></p> </li> <li> <p>Reject infinite values when validating numbers. <a href="https://redirect.github.com/lovell/sharp/pull/4553">#4553</a> <a href="https://github.com/metsw24-max"><code>@metsw24-max</code></a></p> </li> <li> <p>Bound extract region to libvips coordinate limit. <a href="https://redirect.github.com/lovell/sharp/pull/4555">#4555</a> <a href="https://github.com/metsw24-max"><code>@metsw24-max</code></a></p> </li> <li> <p>Verify background colour values are numbers. <a href="https://redirect.github.com/lovell/sharp/pull/4556">#4556</a> <a href="https://github.com/metsw24-max"><code>@metsw24-max</code></a></p> </li> <li> <p>Bound create and raw input dimensions to coordinate limit. <a href="https://redirect.github.com/lovell/sharp/pull/4558">#4558</a> <a href="https://github.com/metsw24-max"><code>@metsw24-max</code></a></p> </li> <li> <p>Tighten recomb and affine matrix verification. <a href="https://redirect.github.com/lovell/sharp/pull/4560">#4560</a> <a href="https://github.com/chatman-media"><code>@chatman-media</code></a></p> </li> <li> <p>Verify cache memory limit to avoid overflow. <a href="https://redirect.github.com/lovell/sharp/pull/4561">#4561</a> <a href="https://github.com/metsw24-max"><code>@metsw24-max</code></a></p> </li> </ul> <h2>v0.35.3-rc.2</h2> <ul> <li>Tighten verification of <code>text</code> dimensions, TIFF tile dimensions and <code>extend</code> values.</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Phil Larson
|
17aadf22ee |
test(core): align executor workflow prompt contract (#3517)
## Summary - align the executor prompt regression with capability-aware workflow creation guidance - keep the no-creation-tool and per-tool cases covered by the adjacent surface-specific test ## Test plan - `pnpm --filter @fusion/core exec vitest run src/__tests__/agent-prompts.test.ts --silent=passed-only --reporter=dot` - `pnpm --filter @fusion/core typecheck` - `pnpm check:changesets` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Updated workflow guidance to prevent assigning workflows to the current task while allowing workflow assignment for newly created or delegated tasks. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: gsxdsm <gsxdsm@users.noreply.github.com> |
||
|
gsxdsm
|
f3e248bb25 |
test: drop the removed subtask handler case, document the star-prompt setting
- useTaskHandlers: deletes `handleSubtaskTasksCreated delegates with addToast` and its `onSubtaskTasksCreated` fixture field. FN-074 removed task splitting; grep confirms no production reference to either symbol remains, so the case was asserting a deleted contract. - settings-default-descriptions: records `githubStarPromptDismissedAt` as internal bookkeeping written by useGitHubStarPrompt rather than a rendered Settings field, which is what that guard requires of every settings key. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> |
||
|
dependabot[bot]
|
bcf353de48 |
chore(deps): bump @capacitor/core from 7.6.1 to 8.5.0 (#3467)
Bumps [@capacitor/core](https://github.com/ionic-team/capacitor) from 7.6.1 to 8.5.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/capacitor/releases">@capacitor/core's releases</a>.</em></p> <blockquote> <h2>8.5.0</h2> <h1><a href="https://github.com/ionic-team/capacitor/compare/8.4.2...8.5.0">8.5.0</a> (2026-07-31)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>cli:</strong> support TypeScript 7 when loading capacitor.config.ts (<a href="https://redirect.github.com/ionic-team/capacitor/issues/8534">#8534</a>) (<a href=" |
||
|
Timoteo
|
23b152f494 |
fix: normalize subscribe for callback-only runtime sessions (#3504)
## Summary - normalize callback-only plugin sessions at the shared runtime boundary - preserve runtime-native subscriptions and isolate subscriber failures - strengthen ACP multi-delta, unsubscribe, and callback-delivery coverage - correct the task environment and unsubscribe contracts ## Why PR #3501 fixed the generic ACP adapter, but workflow steps still call `session.subscribe()` unconditionally. Bundled callback-only runtimes such as Hermes and the vendored Grok/Claude/OMP ACP clients can still return sessions without that method. Handling the compatibility once in `createResolvedAgentSession` closes every current runtime surface without copying the bridge into each adapter. ## Testing - `packages/engine`: `agent-session-helpers.test.ts` — 61 passed - `fusion-plugin-acp-runtime`: `runtime-adapter.test.ts` — 14 passed - `fusion-plugin-acp-runtime`: `process-manager.test.ts` — 15 passed - engine typecheck passed - ACP runtime typecheck passed - changeset format, FNXC date check, ESLint, and `git diff --check` passed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved compatibility with callback-based runtime sessions. - Added reliable subscriptions for text, thinking, and tool activity updates. - Preserved native subscription behavior where available. - Prevented subscriber errors from interrupting event delivery. - Improved unsubscribe behavior for removed handlers. - Improved event delivery during deferred runtime fallback. - Corrected task environment values passed to runtime subprocesses. - **Tests** - Expanded coverage for streaming updates, fallback handling, cleanup, and subscriber isolation. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Phil Larson
|
c192971053 |
fix: remove irregular whitespace from lint gate (#3518)
## Summary - replace a zero-width space in the comment-assertion gate documentation - restore the clean-main ESLint gate without changing scanner behavior ## Test plan - `node scripts/check-no-comment-assertions-in-tests.mjs` - `pnpm exec eslint scripts/check-no-comment-assertions-in-tests.mjs` - `pnpm check:changesets` - `pnpm lint` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Clarified the explanation for a narrowly scoped test-checking exception. * No runtime behavior or user-facing functionality changed. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
gsxdsm
|
72f0bbb503 |
docs: record dashboard api-lane PostgreSQL contention as a suite-infrastructure flake pattern
Three consecutive full-lane runs on the same tree each failed a DIFFERENT file, every one passing in isolation, with hook timeouts arriving alongside PostgreSQL 'Failed query' warnings from two api lanes sharing one database. That is the same class FN-9131 investigated for core's loaded PostgreSQL directory. Deliberately not quarantined: quarantine is file-level and the failing file moves, so it would evict healthy coverage without touching the cause. Recorded with the evidence so the next person does not re-derive it, and so the rescue is aimed at the lane runner's connection/concurrency budget rather than at whichever test lost the race that run. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> |
||
|
gsxdsm
|
cc19584cc4 |
test: stop the quality-runner self-tests from re-entering the suite
These cases live in the `api:curated` lane and spawned `pnpm --filter @fusion/dashboard test` — the very command whose lanes they were running inside. Under a full 15-lane run that child had to resolve pnpm through Corepack while other lanes held the machine, and it intermittently produced nothing at all: the lane log came back empty, the assertion read "0 lanes launched", and a test about the orchestrator failed with no orchestrator defect involved. Seen in both `--all --no-fail-fast` runs today; the file passed alone every time. An earlier attempt only set COREPACK_ENABLE_DOWNLOAD_PROMPT=0, which removed the visible Corepack line but not the failure — the child still produced no output. That fix is replaced rather than kept. They now invoke `node scripts/run-quality-tests.mjs` directly. Every assertion is unchanged (lane names, the 15-lane count, fail-fast labelling, `--` passthrough, which parseArgs already unit-tests), and the one thing the pnpm spawn uniquely proved — that the package script actually points at this orchestrator — is now asserted directly against package.json. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> |
||
|
Fusion Agent
|
cb16f418c7 |
FN-183: ensure local integration branch readiness
Guarantee projects have a usable local integration branch ref across creation, import, and merge workflows. - Add shared integration-branch readiness and repository initialization helpers. - Wire project registration, CLI commands, central storage, and merge execution to establish the ref. - Document the behavior and cover CLI, dashboard, core, and engine integration paths. Files changed: .changeset/fn-183-integration-branch-readiness.md | 7 + docs/architecture.md | 2 +- docs/cli-reference.md | 4 +- docs/getting-started.md | 2 +- docs/settings-reference.md | 2 +- .../auto-git-init-project-registration.md | 21 +++ docs/workspaces.md | 2 +- packages/cli/src/commands/__tests__/init.test.ts | 70 +++++-- .../cli/src/commands/__tests__/project.test.ts | 22 +++ packages/cli/src/commands/init.ts | 26 ++- packages/cli/src/commands/project.ts | 20 ++ packages/core/src/__tests__/git-repository.test.ts | 190 +++++++++++++++++++ .../__tests__/integration-branch-readiness.test.ts | 94 ++++++++++ packages/core/src/central/central-core.ts | 65 +++++-- packages/core/src/git/git-repository.ts | 112 ++++++++++-- .../core/src/git/integration-branch-readiness.ts | 201 +++++++++++++++++++++ packages/core/src/index.gate.ts | 14 ++ packages/core/src/index.ts | 14 ++ packages/core/src/merge/task-merge.ts | 2 +- .../register-project-git-readiness.test.ts | 132 +++++++++++++- .../src/routes/register-project-routes.ts | 31 +++- .../src/__tests__/integration-branch.test.ts | 135 ++++++++++++++ packages/engine/src/__tests__/merger-ai.test.ts | 21 +++ packages/engine/src/merge/integration-branch.ts | 127 ++++++++++++- packages/engine/src/merge/merger-ai.ts | 25 ++- 25 files changed, 1273 insertions(+), 68 deletions(-) Fusion-Task-Id: FN-183 Fusion-Task-Lineage: ee63d45a-3406-4064-b16f-a2fe6dc0ad86 Co-authored-by: Fusion <noreply@runfusion.ai> |
||
|
gsxdsm
|
5378bca7f6 |
test: fix the dashboard quality runner's self-spawning tests
Running the dashboard's REAL test command (`run-quality-tests.mjs`, which shards into 15 lanes) surfaced two failures that a plain `vitest run` never shows — worth noting on its own, since measuring around a package's own command is how a suite gets called green on a number the project does not produce. `scripts/__tests__/run-quality-tests.test.ts` spawns the package's own `pnpm --filter @fusion/dashboard test` to prove the package-command wiring. Inside a full lane run that child inherited a Corepack environment that stopped to ask about downloading pnpm, so it never launched, the lane log came back empty, and the assertion read 0 launched projects. It passed in isolation only because that shell had already resolved pnpm. Both spawn sites now set COREPACK_ENABLE_DOWNLOAD_PROMPT=0; nothing about the assertions changed. Also records PlanningModeModal.planning-flow as a suite-only flake rather than forcing it green: it fails only in lane `app:backfill-3` under four concurrent 6GB shards, passes 83/83 in isolation, and picked a DIFFERENT case on each of two runs — a render-settle timing problem, not a product defect. Recorded as a first sighting; a repeat of the same case is an on-sight quarantine. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> |
||
|
gsxdsm
|
097fa9b403 |
fix(i18n): route the last hardcoded dashboard copy through the catalog
`i18n-lint-baseline` was failing on eight hardcoded strings that shipped without catalog entries: TaskDetailModal's AI-merge-review reconciliation section (title, candidate label, dismiss action, terminal guidance) and ArtifactImageViewer's open-task, close, loading and retry controls. ArtifactImageViewer had no `useTranslation` at all. Keys are authored in `en` and present-but-empty in the six machine-drafted locales, matching the convention already used there (parity requires the key, and an empty value falls back). Note on the pt-BR diff size: that file carried a DUPLICATE `globalModels` section, so re-serializing collapsed it. Verified across all seven locales that this changed no values and removed no keys - only the nine new ones were added. The shadowed copy was already dead at runtime, since JSON parsing keeps the last duplicate. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> |
||
|
gsxdsm
|
64cb17c100 |
FN-9204: advertise a valid memory MCP server version
Make the built-in memory MCP server complete the SDK-validated initialize handshake. - Include a non-empty version in fusion-memory serverInfo responses. - Cover the real SDK handshake, malformed-response skip path, and JSON-RPC envelopes. - Document the protocol requirement and add a patch changeset. Files changed: .changeset/fn-9204-memory-mcp-handshake.md | 7 ++ docs/mcp.md | 2 + .../__tests__/mcp-memory-server-spawn.test.ts | 5 +- .../mcp/__tests__/memory-mcp-handler.test.ts | 7 +- packages/core/src/memory/mcp/memory-mcp-handler.ts | 8 +- .../src/__tests__/mcp-memory-handshake.test.ts | 120 +++++++++++++++++++++ 6 files changed, 146 insertions(+), 3 deletions(-) Fusion-Task-Id: FN-9204 Fusion-Task-Lineage: 0f68bdd5-56fe-4fdb-867f-2a5e0ea4de65 Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai> |
||
|
gsxdsm
|
28a0ebc382 |
docs: index three Stash memory backend docs orphaned by #3494
Add memory-backend-integration.md to Architecture & Development (plus its
missing docs-index back-link) and performance/spawn-storm-attribution.md
and research/stash-vector-search-evaluation.md to Audit Reports. All three
were added by
|
||
|
gsxdsm
|
c82e420ba0 |
fix: repair the dashboard suite and the regressions it was pointing at
Dashboard 441 failures -> 0 across 65 files, worked by three agents. As in the
engine, core and CLI sweeps, the failures were mostly pointing at real
regressions and at behavior changes whose tests were never updated.
Two behavior changes account for the bulk of it. FN-054 made Chat list-first
(the transcript and composer render only inside an explicitly opened
conversation) and FN-9193 docked the conversation list beside the thread, which
deliberately removes the in-thread Back button. Between them they updated about
a dozen of their own tests and left roughly twenty suites asserting the old
navigation - the standing rule this session added, at scale.
The single largest file was not a navigation problem at all: useChat.test.ts's
80 failures were ONE unawaited async act. `stopStreaming()` returns a durable
cancellation promise, and two cases used a concise arrow, so React opened an
async act scope nobody awaited; the queue stayed installed and all 78 later
tests in the file saw a frozen hook. A sibling case already had the corrected
form.
Product defects found and fixed:
- register-chat-routes: FN-047 dropped the null-project branch from the send
path, so with no project selected a send began generation on a different
ChatManager than /cancel and /stream resolve - cancel was a silent no-op.
- ChatView: an imported GitHub link was seeded into a composer that was never
opened, so the operator landed on the conversation list with their link
nowhere on screen; and the thread anchor effect bailed on a missing container
WITHOUT recording state, so a conversation never anchored on open and the next
message growth force-anchored, yanking a reader who had scrolled up.
- NewTaskModal: an unguarded `.length` on an absent `repos` payload threw during
render and blanked the whole modal.
- styles.css: FN-9202's shared `.banner--chrome` referenced `--z-sticky`, which
nothing defined, silently resolving sticky banners' z-index to `auto`.
- The OrcaRouter startup-sync toggle shipped with no i18n catalog entry.
The register-model-routes family - 55 failures across 8 files - was one cause:
fake routers exposing only `get` after a `router.post("/models/refresh")`
registration was added, so every file died at setup.
Also deletes Column.drop-prompt-flags-arrival.test.ts, whose drop surface FN-051
removed, retargeting its late-arriving-flags invariant onto the surviving
context-menu move rather than dropping the coverage.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
||
|
gsxdsm
|
d6c1e27709 |
test: delete comment-pinning assertions in engine and desktop
Part of the repo-wide census for the new "tests assert behavior, never source text or comments" rule. - merger-integration-worktree: deleted "keeps direct-reuse shortcut…", whose sole assertion pinned a `// …Skip acquireTaskWorktree's` comment in merger.ts. - auto-heal-review-lane-callsite-audit: deleted "the DELIBERATE-LITERAL note still claims…", whose sole assertion pinned a comment sentence in project-engine.ts. That file's two real AST/call-site cases are untouched. - electron-builder-config: deleted a pin on "intentionally deferred", which exists only inside YAML comments of desktop-windows.yml. Each of these had a comment as its entire subject, so there was no behavior to preserve — deleting the assertion is the complete fix. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> |
||
|
gsxdsm
|
6fca424852 |
feat: ask for a GitHub star once onboarding finishes (#3516)
## What After an operator **finishes** onboarding, Fusion asks once whether they want to star the repo. If they dismiss it, nothing asks again — on any surface. ## Why Nothing asked at the right moment. The dashboard already had a `GitHubStarPrompt` banner, but it only fired when a task first reached *done*, so someone who completed setup and stopped there was never asked. The CLI (`fn onboard`) had no ask at all. ## How **CLI — `fn onboard`** - The ask runs *after* the completion marker is stamped, so declining (or Ctrl-C on the question) can never cost the operator the setup work they just did. - It prints `https://github.com/Runfusion/Fusion`; it never opens a browser on their behalf. - The non-interactive auto-launch path asks nothing — that flow fires while someone is starting a dev server, and a prompt there is exactly the ambush [ |
||
|
Phil Larson
|
00b7078f79 |
fix: preserve reclaimed worktree branch provenance (#3507)
## Summary - persist engine branch-write provenance when reclaiming an existing task worktree - cover branch-conflict reclaim with a regression assertion for the branch, worktree, and provenance tuple ## Test plan - `pnpm --filter @fusion/engine exec vitest run src/__tests__/executor-worktree.test.ts --silent=passed-only --reporter=dot` - `pnpm --filter @fusion/engine typecheck` - `pnpm check:changesets -- --strict` - `pnpm check:fnxc-future-dates` - `pnpm build` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved recovery when reclaiming existing task worktrees. * Preserved task branch details and worktree paths during branch-conflict recovery. * Recorded whether branch updates originated from the system or an operator for more reliable task state tracking. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: gsxdsm <gsxdsm@users.noreply.github.com> |
||
|
Phil Larson
|
c9f3f11a72 |
fix: allow worktree agents to read user skills (#3506)
## Summary - allow worktree sessions to read the standard user skill root at `~/.agents/skills` - keep sibling `~/.agents` files and all write/edit/Bash access outside the exception - canonicalize existing path components so symlinks cannot escape an allowed skill root - document the boundary and add a patch changeset This extends the same host-skill consistency fixed in #2384: Fusion should not tell an agent to load a skill and then block the skill body. ## Test plan - [x] 15 worktree-boundary tests - [x] `pnpm --filter @fusion/engine typecheck` - [x] scoped ESLint - [x] changeset and FNXC date checks - [x] `pnpm verify:fast` (20 steps, including build and boot smoke) - [x] CLI CI-shape test (72 tests) ## Local gate notes `pnpm test:gate` passed all static checks, 432 engine-core tests, and 184 core unit tests. Its PostgreSQL lane could not authenticate locally (`empty password returned by client`). The full `pi-create-fn-agent.test.ts` run also reaches an unrelated dashboard-chat principal assertion failure already present at the exact `origin/main` SHA; the 15 boundary tests pass. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Worktree agents can read and search skills installed in the standard `~/.agents/skills` directory. - **Bug Fixes** - Preserved worktree protections for writing, editing, and Bash operations. - Blocked access to unrelated files and prevented symlink-based boundary escapes across supported path operations. - Improved access validation for paths that do not yet exist. - **Documentation** - Updated worktree boundary documentation to describe skill access and its restrictions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
gsxdsm
|
12c292ea6b |
test: ban asserting comment text, and fix the prompt it was hiding
Tests must assert behavior, not source text. A test that pins an FNXC block, a
date stamp, or comment prose guards documentation — and AGENTS.md tells authors
to keep those comments current, so the two rules fight and the test loses in the
worst way.
Measured today: grok-runtime-bootstrap.test.ts asserted runTaskMerge's body
contained "FNXC:GrokCliRouting 2026-07-15-10:17". FN-9167 legitimately rewrote
that function and dropped the block while leaving behavior intact; the test went
red, and the fix applied earlier in this sweep was to RE-ADD THE COMMENT to
packages/cli/src/commands/task.ts. A comment returned to shipped source not
because it documented anything true, but to appease a test. Four more such
assertions sat in dashboard CSS tests, each beside a real assertion, each adding
nothing.
- Drops the two prose pins from grok-runtime-bootstrap; its real structural
guard (`not.toContain("mergePluginRunner")`) stays. The product comment stays
too — it is accurate documentation, it was simply never a test's business.
- Adds scripts/check-no-comment-assertions-in-tests.mjs, wired into pretest,
pretest:full, and test:gate:static. It flags the unambiguous case; an earlier
draft that also matched `/*` produced 24 false positives and zero true ones,
because a regex cannot separate comment prose from a path glob.
- Adds the standing rule to AGENTS.md, with an explicit boundary: prose,
comments, and date stamps are never a test subject, while code-construct and
call-site-allowlist guards (no-blocking-shellout, vi-mock resolution, durable
write and emit-surface inventories, legacy tombstones) are a different
category and stay.
Also carries a product fix that the agent-generation tests surfaced: the
system prompt exists in two copies, and `resolvePrompt` returns core's catalog
default, so FN-021 adding the xhigh/max thinking levels to the dashboard copy
alone left every real generation run advertising levels that stop at "high".
Core's copy is synced and both literals now say they must move together.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
||
|
gsxdsm
|
0d11f8dbdf |
FN-9203: Prevent mailbox tab icons from shrinking on mobile
Keep mailbox icons and badges legible across mobile tab and sub-tab surfaces. - Pin mailbox tab icons and badges against flex shrinking while truncating labels safely. - Cover mailbox view, modal, and agent detail tab sizing with computed-style regressions. - Add a patch changeset for the mobile mailbox icon fix. Files changed: .changeset/fn-9203-mailbox-tab-icon.md | 7 ++++ packages/dashboard/app/components/MailboxModal.css | 21 ++++++++++ .../__tests__/AgentDetailView.core.test.tsx | 24 ++++++++--- .../app/components/__tests__/MailboxModal.test.tsx | 32 ++++++++++++--- .../app/components/__tests__/MailboxView.test.tsx | 48 +++++++++++++++------- 5 files changed, 107 insertions(+), 25 deletions(-) Fusion-Task-Id: FN-9203 Fusion-Task-Lineage: f0bef8cb-0194-4661-aba6-8cc19f567c40 Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai> |
||
|
ischindl
|
8fcf4bdbaa |
feat: Stash memory backend — session capture, per-chat backfill, opt-in vector search (#3494)
## Summary Adds the **Stash memory backend** (`memory.backendType=stash`) that connects Fusion's agent memory to the [Stash](https://github.com/Fergana-Labs/stash) product — *knowledge bases for the agent era* ([product site: joinstash.ai](https://joinstash.ai)). Fusion becomes a first-class Stash client: complete chat sessions and finished tasks are captured into Stash, memory is recalled during chat, and Stash sessions are kept in sync with the dashboard (including deletes and archival). **Product:** <https://github.com/Fergana-Labs/stash> · [joinstash.ai](https://joinstash.ai) ## What's included ### 1. Stash memory backend (RUFU-068 / RUFU-121) - New `StashMemoryBackend` (`memory.backendType=stash`) with `stashUrl` / `stashApiKey` settings (global secrets-store `stash-api-key` + per-project override). - **Complete-chat-session capture** keyed by ChatSession id. - Sessions are classified into **per-project folders** (get-or-create, `external_key fusion-<projectId>`, 1h per-process cache) and **soft-deleted with their chat** via `DELETE /api/chat/sessions/:id`. - Per-conversation **memory-focus** read-time scoping (new `0066_chat_session_memory_focus.sql` migration — sequence renumbered 0059→0060→0061→0065→0066 as origin/main claimed the lower numbers); event metadata enriched with `project` / `project_name` / `chat_title`. - Recall queries normalized to single-keyword / explicit-OR ASCII (≤100 chars); shared normalizer export reused by per-turn recall. ### 2. Per-task executor transcript capture (RUFU-122) Finished or failed tasks upload their executor transcript (`agent-log.jsonl`) to Stash as a task session. ### 3. Bulk archive Stash sync (RUFU-125) Archived task-planner chats soft-delete their Stash sessions on bulk archival (paged). The snapshot of doomed session ids is taken *before* the local bulk delete, and the Stash sync runs fire-and-forget so a Stash stall can never delay local archival. ### 4. Per-chat "Preserve to Stash" backfill (RUFU-136) A per-chat action that backfills a chat's full history into Stash, with client-side idempotency and a pre-check that skips already-uploaded content (fail-closed, no duplicate upload on transport failure). - **Session-folder naming fix:** the first project folder is now named "Fusion — <project name>" instead of the bare "Fusion" fallback (the backfill now resolves the central-registry project name, best-effort, never blocking the upload). ### 5. Opt-in semantic (vector) recall (RUFU-126) `stashVectorSearch` setting (default `false` — **zero behavior change until enabled**). For multi-word queries the backend tries Stash's semantic-search endpoint first, then falls back byte-identically to the keyword path. Definitive 404/405/501/503 responses are negatively cached per process. Requires a patched Stash server (new endpoint + `sentence-transformers` + embedding backfill); unpatched servers are transparently bypassed after the first 404. ## Safety - **Opt-in / inert by default:** the default backend remains `qmd`; the Stash backend is inert until `memoryBackendType=stash` + `stashUrl` are set. - All Stash I/O is **best-effort, fail-closed, and non-blocking** — a Stash outage never blocks chat, task completion, or archival. No run-audit content is emitted. ## Testing - Backfill + delete-sync suites (20/20), Stash backend suite (68/68), executor memory / session capture suites, `memory-focus-recalling`, description-guard — all green. - `tsc` clean across core / engine / dashboard. - Live verification: bulk backfill of 21/24 chats completed; the "Preserve to Stash" action is idempotent on re-run. ## Changesets - `@runfusion/fusion` **minor** — Stash memory backend + capture (RUFU-068/121), per-task transcript (RUFU-122), bulk archive sync (RUFU-125), per-chat backfill (RUFU-136), opt-in vector search (RUFU-126) - `@runfusion/fusion` **patch** — backfill session-folder naming fix ## Rebase Note (2026-08-23) Rebased onto `origin/main` `3f448f7292` (v0.77.0-beta.7). Conflicts resolved additively: - `packages/core/src/postgres/schema-applier.ts` + test — upstream's 0062-0065 migrations (task/subtask splitting removal, AI merge review reconciliation, task repository scope, FN-149 review convergence) unioned with this PR's `chat_sessions.memory_focus` migration, which is **renumbered 0065 → 0066** (upstream's FN-149 shipped 0065 canonically on origin/main); `SCHEMA_BASELINE_VERSION` advances to `0066`. - `packages/dashboard/app/components/ChatView.tsx` — upstream's docked chat sidebar resize handlers unioned with the RUFU-136 "Preserve to Stash" backfill handler. - New commit: `settings.memory.*` stash-backend i18n keys added to all 6 secondary locales (RUFU-121/122 parity fix; `pnpm i18n:status` no longer reports any violation introduced by this PR). **Deploy note (operator environments that already ran a pre-rebase build of this PR):** the memory-focus SQL may already be in the schema under ledger row `0065`. Remap that row to `0066` (`UPDATE fusion_schema_migrations SET version = '0066' WHERE version = '0065';`) *before* first boot of a 0066-ceiling binary — otherwise the fresh upstream `0065_fn_149_review_convergence_stage.sql` would be skipped as "already applied". Clean databases (no prior memory-focus row) need no action. **CI note — Lint (lifecycle-column census) is red on the merge base:** `pnpm check:lifecycle-columns --strict` fails identically on pure `origin/main` `3f448f7292` with `packages/core/src/db/legacy-adoption.ts: 0 -> 3` (3 column guards in the U9b legacy-adoption table without a baseline entry or `DELIBERATE-LITERAL` marker). Verified by running the census on a clean origin/main checkout — inherited from the base, not introduced by this PR. Fix belongs upstream; tracked separately. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added Stash memory integration with project configuration and optional semantic search. * Added per-chat memory focus controls and a `/focus` command. * Added “Preserve to Stash” for uploading complete chat history. * Added automatic chat, task transcript, and completion-event capture. * Added project-specific Stash session folders and archive/delete synchronization. * **Bug Fixes** * Improved Stash folder naming and handling of missing branches during no-commit tasks. * **Documentation** * Added setup, configuration, integration, vector-search, and performance guidance. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Fusion <noreply@runfusion.ai> Co-authored-by: gsxdsm <gsxdsm@users.noreply.github.com> |
||
|
Phil Larson
|
1b09c39e4b |
test(dashboard): align room fixtures with docked sidebar (#3511)
## Summary - detect an open conversation by its composer instead of the mobile-only back button - assert the persistent desktop sidebar and mobile back-navigation contracts separately - keep the active-header New Chat expectation aligned with shipped behavior ## Test plan - `FUSION_DASHBOARD_DEEP=1 pnpm --filter @fusion/dashboard exec vitest run --silent=passed-only --reporter=dot app/components/__tests__/ChatView.ios-keyboard.test.tsx app/components/__tests__/ChatView.mobile.test.tsx app/components/__tests__/ChatView.rooms.test.tsx app/components/__tests__/ChatView.title-switcher.test.tsx app/components/__tests__/ChatView.docked-sidebar.test.tsx app/components/__tests__/ChatView.sessions-rooms.test.tsx` - `pnpm --filter @fusion/dashboard typecheck` - `pnpm exec eslint packages/dashboard/app/components/__tests__/ChatView.rooms.test.tsx` - `node scripts/check-changeset-format.mjs --strict` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Expanded coverage for navigating between chat lists and conversation details. - Verified selecting a different room updates the active room and conversation header. - Added responsive checks for desktop and mobile layouts. - Verified support for both room chats and direct conversations. - Confirmed mobile users see **New Chat** in the active header. - Confirmed desktop navigation presents list and detail views without an unnecessary back button. - Improved viewport isolation and cleanup between responsive tests. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Phil Larson
|
87e7369575 |
fix(i18n): restore JIRA settings locale parity (#3503)
## Summary - restore the 21 JIRA settings keys in all six secondary app catalogs - return the workspace i18n parity gate to green - add patch release metadata ## Test Plan - `pnpm i18n:status` - `pnpm check:changesets` - `pnpm --filter @fusion/dashboard build` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Localization** * Added Jira settings translation coverage for Spanish, French, Korean, Brazilian Portuguese, Simplified Chinese, and Traditional Chinese. * Standardized availability of Jira configuration labels across supported dashboard locales, including URLs, credentials, scopes, and issue templates. * **Documentation** * Added release metadata for the localization update. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: gsxdsm <gsxdsm@users.noreply.github.com> |
||
|
Phil Larson
|
38edc2366b |
fix(core): restore executor workflow creation guidance (#3513)
## Summary - restore explicit executor guidance for assigning workflows to tasks the agent creates - keep the existing prohibition on rerouting the task currently being executed - restore parity between both built-in executor prompt variants and their regression test ## Test plan - `pnpm --filter @fusion/core exec vitest run --silent=passed-only --reporter=dot src/__tests__/agent-prompts.test.ts` - `pnpm --filter @fusion/core typecheck` - `pnpm check:changesets` - `pnpm exec eslint packages/core/src/agents/agent-prompts.ts` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Improvements** * Executor workflow guidance now appears only when task creation or delegation capabilities are available. * Built-in executor prompts provide clearer task-assignment instructions based on available capabilities. * Custom executor prompts remain unchanged. * Removed outdated workflow-setting guidance when task-management capabilities are unavailable. * **Tests** * Added coverage for task creation, delegation, and capability-specific workflow guidance scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Phil Larson
|
6c2a461816 |
test(core): refresh lane-wiring baseline after merge readiness (#3515)
## Summary - Re-record the lane-wiring baseline after #3514 removed the final unwired merge-readiness call site. - Normalize the duplicate `self-healing.ts` key while regenerating the canonical JSON baseline. ## Test Plan - `node scripts/check-lane-wiring.mjs` - `git diff --check` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated internal baseline tracking to remove an obsolete merge-task entry. * No user-facing functionality or behavior changed. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
gsxdsm
|
9838f42076 |
fix: repair core and CLI suites, plus a PG table-registry omission
Core 32 failures -> 0 (5,981 passing); CLI 46 -> 0 (2,021 passing). Three agents per package, root-cause fixes only. One product defect, same class as FN-9059 and found the same way — by a test that leaked state between runs: `projectTableNames` was missing SEVENTEEN tables the schema declares (current_plan_evidence, spec_locks, spec_drift_reports, symbol_locks, configuration_revisions, chat_tags, chat_session_tags, mission_lineage_stops, task_verification_requests, unplanned_execution_blocks, workflow_agent_capacity_leases and the six task_lifecycle_* tables). That list drives BOTH the PG test-harness per-test reset and production health compaction, so those tables were never truncated between tests (a plan-evidence version counter carried forward, making whole-file runs disagree with isolated ones) and never VACUUM/ANALYZEd in production. Registered, with project-table-registry.test.ts as a ratchet — verified it fails on an unregistered new table naming the offender. Everything else was drift behind deliberate changes: branch-write provenance, FN-073 dependency validation, the FN-9191 pre-merge merge gate, U11's triage/ planning lane merge, refinement workflow coming from the ORIGIN selection, async-converted provider registration, a barrel mock missing exports a guard added, and several source-pinned inventories broken by module moves. Tests for removed features were deleted with their removing commit cited. Also fixes a vitest config gap where @fusion/core/mcp-builtin-servers resolved only to dist/, which was breaking test COLLECTION in unrelated CLI files and had been misread as transient cross-agent noise. Quarantines mission-store.pg's concurrent-claim race (second sighting): it holds a transaction open, sleeps 250ms and asserts the rival has not settled, which fails under parallel load. An A/B against the registry change above looked causal on one run and did not reproduce on three — that coincidence is the flake itself, and rescue needs a real lock-wait probe rather than a longer sleep. Core's config now inlines its exclude array, because check-quarantine-ledger.mjs cannot resolve a variable reference and silently reported the ledger unpaired. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> |
||
|
gsxdsm
|
9d1bd393d8 |
FN-9202: Unify dashboard banner styling
Standardize dashboard notices on a shared, token-driven banner shell. - Add a reusable Banner primitive with consistent tones, layouts, actions, and dismissal behavior. - Migrate dashboard notification banners away from bespoke shells and left accent borders. - Document and test banner styling invariants, including token-only CSS lengths and colors. - Add a patch changeset for the published dashboard bundle. Files changed: .changeset/fn-9202-banner-style-unification.md | 7 ++ docs/dashboard-guide.md | 4 + .../app/__tests__/banner-style-consistency.test.ts | 25 ++++ .../app/components/ApprovalNotificationBanner.css | 10 -- .../app/components/ApprovalNotificationBanner.tsx | 5 +- packages/dashboard/app/components/Banner.css | 81 ++++++++++++ packages/dashboard/app/components/Banner.tsx | 78 ++++++++++++ .../app/components/CapacityRiskBanner.css | 50 +------- .../app/components/CapacityRiskBanner.tsx | 39 +++--- .../app/components/CliBinaryInstallBanner.css | 126 ++----------------- .../app/components/CliBinaryInstallBanner.tsx | 14 +-- .../app/components/DbCorruptionBanner.css | 18 +-- .../app/components/DbCorruptionBanner.tsx | 5 +- .../app/components/EngineStatusBanner.css | 94 ++------------ .../app/components/EngineStatusBanner.tsx | 48 +++---- .../app/components/EngineUnavailableBanner.css | 42 +------ .../app/components/EngineUnavailableBanner.tsx | 21 ++-- .../app/components/MergeAdvanceNotice.css | 129 +++---------------- .../app/components/MergeAdvanceNotice.tsx | 36 +++--- .../app/components/MigrationInProgressBanner.css | 25 ---- .../app/components/MigrationInProgressBanner.tsx | 19 +-- .../app/components/OAuthReloginBanner.css | 53 +------- .../app/components/OAuthReloginBanner.tsx | 26 +--- .../app/components/SessionNotificationBanner.css | 16 +-- .../app/components/SessionNotificationBanner.tsx | 5 +- .../app/components/SetupWarningBanner.css | 106 +--------------- .../app/components/SetupWarningBanner.tsx | 31 +---- .../app/components/SqliteMigrationBanner.css | 40 +----- .../app/components/SqliteMigrationBanner.tsx | 33 ++--- .../app/components/TaskIdIntegrityBanner.css | 18 +-- .../app/components/TaskIdIntegrityBanner.tsx | 5 +- .../dashboard/app/components/TestModeBanner.css | 18 --- .../dashboard/app/components/TestModeBanner.tsx | 12 +- .../app/components/UpdateAvailableBanner.css | 139 +++------------------ .../app/components/UpdateAvailableBanner.tsx | 22 ++-- .../app/components/__tests__/Banner.test.tsx | 48 +++++++ 36 files changed, 450 insertions(+), 998 deletions(-) Fusion-Task-Id: FN-9202 Fusion-Task-Lineage: 14762201-55e5-4124-a897-9667c3a1ab84 Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai> |
||
|
gsxdsm
|
4475342145 |
docs: record a first-sighting PG setup-hook flake in the observed register
`handoff-to-review-atomicity.pg.test.ts` aborted its `beforeAll` at the 15s budget on the first `pnpm test:gate` of a session; not reproduced in 8 later runs across three shapes (gate x2, pg-gate x3, isolated x3). Same mode as entries 6 and 7, but narrower: it happened under the capped four-fork lane with two selected files, so fork oversubscription does not explain it. Recorded the cold-cluster correlation as a hypothesis rather than a finding — reproducing it means stopping the embedded cluster, and this host runs a live Fusion instance. Discloses that the failing run's full output was lost to a tail pipe, and that inline quarantine was unavailable regardless (quarantinedCoreTests must stay empty); eviction of a transactional-invariant gate file is owner-escalated. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> |
||
|
gsxdsm
|
08f8c26ec1 |
fix: honor the workflow-principal hold cooldown on the dispatch path
The U4 executor peel (#3317) rewrote executor.ts from a pre-change base and dropped `isPrincipalHoldCoolingDown`, re-inlining the read inside executeWorkflowGraph behind `!opts?.alreadyClaimed` — a flag its only caller, executeCore, always sets. The ladder kept recording and clearing correctly, so it read as working while never once deferring a dispatch. Without it, an unroutable role pool re-enters the graph on every dispatch only to re-fence and re-park: one graph run, two work-item writes and two audit rows per pass, for a condition that clears only when an operator enables or adds an agent. The `!repeated` log suppression keeps that flood invisible after the first line. Restore the guard in executeCore, ahead of the graphRouting claim. Position is load-bearing in both directions: returning after the claim would strand it (graphRunnerOwnsClaim stops the finally from cleaning up), which is also why the inner check must keep its alreadyClaimed gate. Make the ladder a primitive with one exported writer and one exported reader so a lost reader is a lost reference the compiler can see, rather than a .get() that quietly moved somewhere its guard could never be true. Its test-mode zero is now read at record time; bound at module load it collapsed the cooldown to until === now under VITEST, so no test could have caught this. Regression test asserts the invariant on both entry surfaces plus the negatives that keep the guard from becoming a permanent block. Mutation-checked: with the guard disabled the two dispatch-deferral cases fail. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> |
||
|
gsxdsm
|
39812f4898 |
test: quarantine one suite-only flake, record another, fix the lockstep guard
Full engine suite at
|
||
|
gsxdsm
|
e259b1a290 |
fix: retighten lane-wiring baseline after merge-readiness wiring
#3514 removed the last unwired task-merge review-lane call site but left the ratchet allowance at 1, so every PR against main failed check:lane-wiring on a drop. |
||
|
Phil Larson
|
bc82d8e0e1 |
fix(core): thread review lanes through merge readiness (#3514)
## Summary - thread resolved review lanes through `isTaskReadyForMerge` - preserve required pre-merge step filtering - add coverage for a renamed review lane ## Test plan - `pnpm --filter @fusion/core exec vitest run --silent=passed-only --reporter=dot src/__tests__/task-merge.test.ts` - `pnpm --filter @fusion/core typecheck` - `pnpm check:lane-wiring` - `pnpm check:changesets` - `pnpm exec eslint packages/core/src/merge/task-merge.ts packages/core/src/__tests__/task-merge.test.ts` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Custom review lanes are now honored during merge-readiness checks and auto-merge processing. * Renamed workflow lanes correctly determine whether tasks can merge. * Tasks resumed from a paused state are routed and evaluated using the appropriate review lane. * The default `in-review` lane remains supported when no custom review lanes are configured. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: gsxdsm <gsxdsm@users.noreply.github.com> |
||
|
Phil Larson
|
febe375b14 |
fix(core): preserve merge finalization review lanes (#3508)
## Summary - Forward project review lanes and required pre-merge steps through merge-confirmed finalization. - Cover custom review-lane and required-step blockers in the merge finalization tests. - Correct future-dated FNXC stamps that were blocking the shared lint gate. ## Test Plan - `corepack pnpm --filter @fusion/core exec vitest run src/__tests__/task-merge.test.ts --silent=passed-only --reporter=dot` - `corepack pnpm --filter @fusion/core typecheck` - `corepack pnpm check:lifecycle-columns` - `corepack pnpm check:lane-wiring` - `corepack pnpm check:fnxc-future-dates` - `corepack pnpm check:changesets --strict` - `git diff --check` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Confirmed merge finalization now preserves the selected review lane and applies its resolved review requirements. - Required pre-merge steps are correctly enforced for both durable and non-durable merges. - **Tests** - Added coverage for review-lane handling and pre-merge blockers across merge paths. - **Documentation** - Added release notes documenting the merge finalization fix. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
gsxdsm
|
a97aa84a20 |
fix: remove debug probes swept into ab9789f0a8 by mistake
|
||
|
gsxdsm
|
ab9789f0a8 |
fix: correct workspace review fingerprint range and land-intent resolve gating
Two product defects surfaced by workspace-e2e's remaining failures. 1. A merge-boundary fence silently did not apply. captureWorkspaceReviewEvidence computes a repository's file list over baseCommitSha..<resolved task branch>, but computeReviewDiffFingerprint hardcoded baseRef..HEAD. For a workspace entry whose checkout sits on the integration branch those are different ranges, so the fingerprint did not describe the files captured beside it: a diverged checkout hard-failed an approved repository as content-changed, and a checkout at the base produced an empty diff -> undefined fingerprint -> the repo dropped out of mergeBoundaryFingerprints, so BOTH the approval-missing and content-changed fences stopped applying to it at all. computeReviewDiffFingerprint now takes an optional headRef; workspace evidence passes the resolved task branch. The singular-review caller, whose worktree IS the branch, keeps the ambient HEAD default. 2. Land intents were recorded and resolved under different conditions. landOneRepo records an intent only when ctx.workspaceLand is set, which landWorkspaceTask passes only for remote targets, but the resolve side was gated on durableLandLease alone. A local-only land therefore resolved an intent that was never recorded, got "missing", and failed a fully-landed repo as a partial land AFTER its integration ref had advanced. Resolve now uses the same condition as record. The approveWorkspaceReview helper's "reviewStep called exactly once" constant only held because defect 1 suppressed a repository; it now derives the expected count from the same production capture the review loop uses. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> |